-
Notifications
You must be signed in to change notification settings - Fork 1.6k
view_endpoint: fix error #12343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
view_endpoint: fix error #12343
Conversation
This pull request involves a potential template rendering modification that could introduce unexpected behavior by allowing unequal list zipping, and includes some test file updates to expand test coverage. 💭 Unconfirmed Findings (2)
All finding details can be found in the DryRun Security Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Fixes #12295
The view endpoint page (used to view a host) was broken since #11952.
The problem is that the
zip
here cannot be set to bestrict
as the lists are deliberately created with different lengths. I believe this is done to be a "performant" way to pad the endpoints intonum_cols
columns. Any solution that could work withstrict=True
would have to determine the length of the queryset with endpoints. This could be considered inefficient for large querysets (even though maybe django just does a count() query). I believe we should just accept that thiszip
needsstrict=False
.Added a UI test to prevent regressions. #12344 should prove that it fails if an error is present in the view_endpoint code.