Skip to content

Updated daemonset.tf, new versions for node-driver-registrar #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

good92
Copy link
Contributor

@good92 good92 commented Aug 16, 2022

  1. new versions for node-driver-registrar and URL to check manually
  2. Use log_level for verbosity

1. new versions for node-driver-registrar and URL to check manually
2. Use log_level for verbosity
@@ -45,7 +45,11 @@ resource "kubernetes_daemonset" "efs" {

container {
name = "efs-plugin"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is specified twice

# https://gallery.ecr.aws/eks-distro/kubernetes-csi/node-driver-registrar depends on the K8s version and minor updates
image = "public.ecr.aws/eks-distro/kubernetes-csi/node-driver-registrar:v2.1.0-eks-1-20-19"
#image = "public.ecr.aws/eks-distro/kubernetes-csi/node-driver-registrar:v2.1.0-eks-1-18-16"
args = ["--csi-address=$(ADDRESS)", "--kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)", "--v=${var.log_level}"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

args as well mentioned twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants