Skip to content

Added support for IKEA E2123 SYMFONISK sound remote, gen 2. #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 28, 2025

Conversation

yarafie
Copy link
Contributor

@yarafie yarafie commented Mar 2, 2025

  • Added support for IKEA E2123 SYMFONISK sound remote, gen 2.

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

Added support for IKEA E2123 SYMFONISK sound remote, gen 2.

Checklist*

  • [Y] I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • [Y] I properly tested proposed changes on my system and confirm that they are working as expected.
  • [Y] I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Copy link
Contributor

github-actions bot commented Mar 2, 2025

Hey @yarafie, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@yarafie yarafie changed the title IKEA E2123 SYMFONISK sound remote gen 2 Added support for IKEA E2123 SYMFONISK sound remote, gen 2. Mar 2, 2025
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Hey @yarafie,

❌ It looks like there are some issues with your contribution. Don't worry, here's some additional information and guidance on how to solve them.

  • Your files are not properly formatted. Did you remember to run npm run format before submitting your changes?

Please fix reported issues, then submit your updates here. If you have any questions or doubts, you can always contact a project maintainer. :)

Thanks!

Copy link
Contributor

github-actions bot commented Mar 2, 2025

Copy link
Contributor

github-actions bot commented Mar 8, 2025

Copy link
Contributor

github-actions bot commented Mar 9, 2025

Copy link
Contributor

github-actions bot commented Mar 9, 2025

Copy link
Contributor

github-actions bot commented Mar 18, 2025

Hey @yarafie,

❌ It looks like there are some issues with your contribution. Don't worry, here's some additional information and guidance on how to solve them.

Please fix reported issues, then submit your updates here. If you have any questions or doubts, you can always contact a project maintainer. :)

Thanks!

Copy link
Contributor

github-actions bot commented Mar 18, 2025

@EPMatt
Copy link
Owner

EPMatt commented Mar 18, 2025

Thanks for your contribution @yarafie!

This new blueprint here uses the same logic we are currently discussing in #693. Hence, let's first wait for #693 to be approved and merged. We will then apply the agreed changes here.

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Hey @yarafie, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@yarafie yarafie force-pushed the IKEA-E2123-SYMFONISK-sound-remote-gen-2 branch from da8e04f to 13a2cb7 Compare March 20, 2025 15:51
Copy link
Contributor

github-actions bot commented Mar 20, 2025

Hey @yarafie,

❌ It looks like there are some issues with your contribution. Don't worry, here's some additional information and guidance on how to solve them.

  • Your files are not properly formatted. Did you remember to run npm run format before submitting your changes?

Please fix reported issues, then submit your updates here. If you have any questions or doubts, you can always contact a project maintainer. :)

Thanks!

Copy link
Contributor

github-actions bot commented Mar 20, 2025

@yarafie yarafie force-pushed the IKEA-E2123-SYMFONISK-sound-remote-gen-2 branch from 7248c79 to b1d12ec Compare March 21, 2025 14:36
Copy link
Contributor

github-actions bot commented Mar 21, 2025

Hey @yarafie, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@EPMatt
Copy link
Owner

EPMatt commented Mar 26, 2025

@yarafie is this ready as well? I can take care of the merge

@yarafie
Copy link
Contributor Author

yarafie commented Mar 26, 2025

@yarafie is this ready as well? I can take care of the merge

Yes go for it

@EPMatt EPMatt force-pushed the IKEA-E2123-SYMFONISK-sound-remote-gen-2 branch from 38ffcd5 to 99ff9f1 Compare March 28, 2025 12:45
Copy link
Contributor

Hey @EPMatt, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Copy link
Contributor

github-actions bot commented Mar 28, 2025

@EPMatt EPMatt merged commit 8a6915c into EPMatt:main Mar 28, 2025
5 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 28, 2025
…SK sound remote, gen 2. (#704)

* Added support for IKEA E2123 SYMFONISK sound remote, gen 2.

* Added support for IKEA E2123 SYMFONISK sound remote, gen 2.

* Added missing short press actions and fixed some documentation mappings.

* Fixed yaml and updated docs for ikea_e2123

* Fixed yaml and updated docs for ikea_e2123

* Added ability to enable/disable Long/Double Actions for dots buttons.

* Update ikea_e2123 blueprint with button optimizations. [Issue#70]

* Update ikea_e2123

* Added support for IKEA E2123 SYMFONISK sound remote, gen 2

* Added support for IKEA E2123 SYMFONISK sound remote, gen 2

* docs: bump version to 2025.03.28, update changelog

---------

Co-authored-by: EPMatt <[email protected]>
@yarafie yarafie deleted the IKEA-E2123-SYMFONISK-sound-remote-gen-2 branch March 28, 2025 18:04
Copy link
Contributor

Hi there,

🔒 This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you want to submit a contribution to the project, you can open a new PR.

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants