[ODS-6434]Rebuild Database Templates build -Skip already successful package creation from working branch #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation from working branch
…mplate.TPDM.PostgreSQL ,EdFi.Ods.Populated.Template.TPDM ,EdFi.Ods.Populated.Template.TPDM.PostgreSQL package version
…M, Sample new package version Step
…i.Ods.Populated.Template ,EdFi.Ods.Populated.Template.PostgreSQL new package version
…e.PostgreSQL ,EdFi.Ods.Populated.Template ,EdFi.Ods.Populated.Template.PostgreSQL package version
…mplate.TPDM.PostgreSQL ,EdFi.Ods.Populated.Template.TPDM ,EdFi.Ods.Populated.Template.TPDM.PostgreSQL package version
🔍 Vulnerabilities of
|
| digest | sha256:2e62e869106f3d98a1dcbbc40a6c7f919ef3197ab486d76710df47a5aa2a237e |
| vulnerabilities |     |
| platform | linux/amd64 |
| size | 698 MB |
| packages | 260 |
📦 Base Image ubuntu:22.04
| also known as |
|
| digest | sha256:2af372c1e2645779643284c7dc38775e3dbbc417b2d784a27c5a9eb784014fb8 |
| vulnerabilities |   |
mjaksn
approved these changes
Aug 27, 2024
vimayya
reviewed
Aug 28, 2024
build.githubactions.ps1
Outdated
| } | ||
| } | ||
|
|
||
| function AddOrUpdateRepositoriesJson { |
There was a problem hiding this comment.
Suggested change
| function AddOrUpdateRepositoriesJson { | |
| function CreateOrUpdateRepositoriesJson { |
| $url = "https://api.github.com/repos/Ed-Fi-Alliance-OSS/Ed-Fi-Extensions/branches/${{ env.current_branch }}" | ||
| .\build.githubactions.ps1 TestBranchExists -RepoName "Ed-Fi-Extensions" -BranchName "${{ env.current_branch }}" -Url $url | ||
|
|
||
| - name: Check any failed previous Workflow Run exist in current branch |
There was a problem hiding this comment.
Suggested change
| - name: Check any failed previous Workflow Run exist in current branch | |
| - name: Check for any failed previous workflow runs in the current branch |
| if_no_artifact_found: ignore | ||
| continue-on-error: true | ||
|
|
||
| - name: Read each repo last commit for repo Ed-Fi-ODS-Implementation and stored it in repositories.json |
There was a problem hiding this comment.
Suggested change
| - name: Read each repo last commit for repo Ed-Fi-ODS-Implementation and stored it in repositories.json | |
| - name: Read the last commit for Ed-Fi-ODS-Implementation and store it in repositories.json |
| $implementationUrl = "https://api.github.com/repos/Ed-Fi-Alliance-OSS/Ed-Fi-ODS-Implementation/commits?sha=$branchName&since=$sinceDate&page=1&per_page=200" | ||
| .\build.githubactions.ps1 'AddOrUpdateRepositoriesJson' -Url $implementationUrl -RepoName 'Ed-Fi-ODS-Implementation' | ||
|
|
||
| - name: Read each repo last commit for repo Ed-Fi-ODS and stored it in repositories.json |
There was a problem hiding this comment.
Suggested change
| - name: Read each repo last commit for repo Ed-Fi-ODS and stored it in repositories.json | |
| - name: Read the last commit for Ed-Fi-ODS and store it in repositories.json |
| $odsUrl = "https://api.github.com/repos/Ed-Fi-Alliance-OSS/Ed-Fi-ODS/commits?sha=$branchName&since=$sinceDate&page=1&per_page=200" | ||
| .\build.githubactions.ps1 'AddOrUpdateRepositoriesJson' -Url $odsUrl -RepoName 'Ed-Fi-ODS' | ||
|
|
||
| - name: Read each repo last commit for repo Ed-Fi-Extensions and stored it in repositories.json |
There was a problem hiding this comment.
Suggested change
| - name: Read each repo last commit for repo Ed-Fi-Extensions and stored it in repositories.json | |
| - name: Read the last commit for Ed-Fi-Extensions and store it in repositories.json |
| $url = "https://api.github.com/repos/Ed-Fi-Alliance-OSS/Ed-Fi-Extensions/actions/workflows/$workflow_file_name/runs?branch=${{ env.current_branch }}" | ||
| .\build.githubactions.ps1 'WorkflowCheck' -Url $url -ExpectedStatus 'completed' -ExpectedConclusions @('success') -StatusEnvName 'TPDM_successful_runexist' | ||
|
|
||
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Extensions.TPDM package Version |
There was a problem hiding this comment.
Suggested change
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Extensions.TPDM package Version | |
| - name: Check if configuration.packages.json has an updated EdFi.Ods.Extensions.TPDM package Version |
| $url = "https://api.github.com/repos/Ed-Fi-Alliance-OSS/Ed-Fi-ODS/actions/workflows/$workflow_file_name/runs?branch=${{ env.current_branch }}" | ||
| .\build.githubactions.ps1 'WorkflowCheck' -Url $url -ExpectedStatus 'completed' -ExpectedConclusions @('success') -StatusEnvName 'populated_template_successful_runexist' | ||
|
|
||
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Populated.Template package Version |
There was a problem hiding this comment.
Suggested change
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Populated.Template package Version | |
| - name: Check if configuration.packages.json has an updated EdFi.Ods.Populated.Template package Version |
| $url = "https://api.github.com/repos/Ed-Fi-Alliance-OSS/Ed-Fi-ODS/actions/workflows/$workflow_file_name/runs?branch=${{ env.current_branch }}" | ||
| .\build.githubactions.ps1 'WorkflowCheck' -Url $url -ExpectedStatus 'completed' -ExpectedConclusions @('success') -StatusEnvName 'populated_template_postgreSQL_successful_runexist' | ||
|
|
||
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Populated.Template.PostgreSQL package Version |
There was a problem hiding this comment.
Suggested change
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Populated.Template.PostgreSQL package Version | |
| - name: Check if configuration.packages.json has an updated EdFi.Ods.Populated.Template.PostgreSQL package Version |
| $url = "https://api.github.com/repos/Ed-Fi-Alliance-OSS/Ed-Fi-ODS/actions/workflows/$workflow_file_name/runs?branch=${{ env.current_branch }}" | ||
| .\build.githubactions.ps1 'WorkflowCheck' -Url $url -ExpectedStatus 'completed' -ExpectedConclusions @('success') -StatusEnvName 'minimal_template_successful_runexist' | ||
|
|
||
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Minimal.Template package Version |
There was a problem hiding this comment.
Suggested change
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Minimal.Template package Version | |
| - name: Check if configuration.packages.json has an updated EdFi.Ods.Minimal.Template package Version |
| $url = "https://api.github.com/repos/Ed-Fi-Alliance-OSS/Ed-Fi-ODS/actions/workflows/$workflow_file_name/runs?branch=${{ env.current_branch }}" | ||
| .\build.githubactions.ps1 'WorkflowCheck' -Url $url -ExpectedStatus 'completed' -ExpectedConclusions @('success') -StatusEnvName 'minimal_template_postgreSQL_successful_runexist' | ||
|
|
||
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Minimal.Template.PostgreSQL package Version |
There was a problem hiding this comment.
Suggested change
| - name: Compare already configuration.packages.json updated with EdFi.Ods.Minimal.Template.PostgreSQL package Version | |
| - name: Check if configuration.packages.json has an updated EdFi.Ods.Minimal.Template.PostgreSQL package Version |
…e.PostgreSQL ,EdFi.Ods.Populated.Template ,EdFi.Ods.Populated.Template.PostgreSQL package version
…mplate.TPDM.PostgreSQL ,EdFi.Ods.Populated.Template.TPDM ,EdFi.Ods.Populated.Template.TPDM.PostgreSQL package version
|
@vimayya All review comments are fixed . Ready for Review again . Thanks |
…e.PostgreSQL ,EdFi.Ods.Populated.Template ,EdFi.Ods.Populated.Template.PostgreSQL package version
…mplate.TPDM.PostgreSQL ,EdFi.Ods.Populated.Template.TPDM ,EdFi.Ods.Populated.Template.TPDM.PostgreSQL package version
vimayya
approved these changes
Aug 29, 2024
mjaksn
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below is a structured breakdown of each use case:
Use Case 1:
Scenario:
A new commit occurs in one of the three repositories (Ed-Fi-ODS, Ed-Fi-ODS-Implementation, or Ed-Fi-Extensions).
The workflow begins by updating the CodeGen package but fails before completing.
Expected Behavior:
In the first run, the workflow updates the CodeGen package version. However, the workflow fails after this update, preventing the completion of other package updates.
Example Workflow Run:
Failed after updating CodeGen package.
Use Case 2:
Scenario:
The workflow is re-triggered after the failure in Use Case 1.
It should skip the CodeGen package update since it was already updated and continue updating the Extensions packages (TPDM, Sample, Homograph).
Expected Behavior:
The workflow should resume from the Extensions package update, bypassing the CodeGen package. However, it fails again after updating the Extensions packages.
Example Workflow Run:
Failed after updating Extensions packages.
Use Case 3:
Scenario:
The workflow is re-triggered after the failure in Use Case 2.
It should skip both the CodeGen and Extensions package updates, resuming with updates to the EdFi.Ods.Minimal.Template, EdFi.Ods.Minimal.Template.PostgreSQL, EdFi.Ods.Populated.Template, and EdFi.Ods.Populated.Template.PostgreSQL packages.
Expected Behavior:
The workflow should skip the already updated CodeGen and Extensions packages, but it fails after attempting to update the Minimal and Populated templates.
Example Workflow Run:
Failed after updating Minimal and Populated templates.
Use Case 4:
Scenario:
The workflow is re-triggered after the failure in Use Case 3.
It should skip the CodeGen, Extensions, and Minimal/Populated template updates and continue with the updates for EdFi.Ods.Minimal.Template.TPDM, EdFi.Ods.Minimal.Template.TPDM.PostgreSQL, EdFi.Ods.Populated.Template.TPDM, and EdFi.Ods.Populated.Template.TPDM.PostgreSQL packages.
Expected Behavior:
The workflow successfully completes by updating the TPDM-related templates without any failures.
Example Workflow Run:
Successful completion after TPDM package updates.
Validation Steps:
Branch Consistency Across Repositories:
Ensure the working branch exists in all three repositories (Ed-Fi-ODS, Ed-Fi-ODS-Implementation, Ed-Fi-Extensions).
Check for Previous Workflow Failures:
Before starting the process, check if there was a failure in the last run. If so, determine whether any packages were updated successfully.
Handling New Commits:
If new commits are detected after a failed workflow, ensure the workflow resumes from where it left off by skipping already updated packages.