Makefile: generate and install requirements.txt files for Python plugins #7864
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
install-requirements.txt-file
branch
from
d7ad639 to
17722fd
Compare
vincenzopalazzo
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
ACK 17722fd
Modified the commit body to make the CI happy, now lets wait the CI
|
some of the CI failure liek the mac os looks like unrelated |
rustyrussell
force-pushed
the
install-requirements.txt-file
branch
from
17722fd to
ae6fab1
Compare
|
Rebased on master: wss is now the only Python plugin! |
rustyrussell
force-pushed
the
install-requirements.txt-file
branch
2 times, most recently
from
b3a4cbf to
aee36cc
Compare
rustyrussell
force-pushed
the
install-requirements.txt-file
branch
5 times, most recently
from
3017b8a to
4fdd249
Compare
…nts.txt Without this: ``` cd plugins/wss-proxy && poetry export --without-hashes > ../../plugins/wss-proxy-requirements.txt The command "export" does not exist. make: *** [plugins/wss-proxy-requirements.txt] Error 1 ``` Signed-off-by: Rusty Russell <[email protected]>
…ins. Doesn't automate the install, but at least provides some tools for users to install the requirements on their systems Changelog-Added: Install: we now supply requirements.txt file for Python plugin (i.e. wss-proxy). See-also: ElementsProject#7665 Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
install-requirements.txt-file
branch
from
4fdd249 to
498238b
Compare
|
This is definitely getting us in the right direction. I think poetry-plugin-export has a v1.9.0, but for poetry we want a v1.8.5 or v2.0.0. |
|
Let's defer this, there are bigger fish to fry... |
endothermicdev
force-pushed
the
install-requirements.txt-file
branch
from
03947f7 to
148e918
Compare
|
It's in Rust now, so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't automate the install, but at least provides some tools for users to install the requirements on their systems
See-also: #7665