-
-
Notifications
You must be signed in to change notification settings - Fork 910
Update worldedit-sponge to API 8 #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## version/7.2.x #1771 +/- ##
===================================================
- Coverage 10.77% 10.66% -0.12%
Complexity 1090 1090
===================================================
Files 824 831 +7
Lines 37914 38320 +406
Branches 4318 4371 +53
===================================================
Hits 4085 4085
- Misses 33634 34040 +406
Partials 195 195
Continue to review full report at Codecov.
|
153b43f
to
706770b
Compare
706770b
to
3d69c85
Compare
3d69c85
to
f828f76
Compare
Remove text adapter Debugging the bugs out
604ef7e
to
4555236
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my look-overs and testing this appears to be good, aside from otherwise noted external issues
This replaces #1289 and updates to the current tip, along with incorporating #1766 for a better lifecycle. It's currently non-functional due to what I presume is Sponge bugs, but once it's all ironed out and confirmed to be working, it'll become ready for review! Feel free to take a look now.