Skip to content

Update worldedit-sponge to API 8 #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 29, 2022
Merged

Conversation

octylFractal
Copy link
Member

@octylFractal octylFractal commented Jun 5, 2021

This replaces #1289 and updates to the current tip, along with incorporating #1766 for a better lifecycle. It's currently non-functional due to what I presume is Sponge bugs, but once it's all ironed out and confirmed to be working, it'll become ready for review! Feel free to take a look now.

@octylFractal octylFractal added platform:sponge Specific to the Sponge platform type:feature-request Request for something new status:accepted Will be fixed / added to WorldEdit, eventually labels Jun 5, 2021
@octylFractal octylFractal added this to the 7.2.6 milestone Jun 5, 2021
@octylFractal octylFractal requested a review from a team June 5, 2021 00:10
@octylFractal octylFractal marked this pull request as draft June 5, 2021 00:10
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #1771 (ac8ac86) into version/7.2.x (ab61a84) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             version/7.2.x    #1771      +/-   ##
===================================================
- Coverage            10.77%   10.66%   -0.12%     
  Complexity            1090     1090              
===================================================
  Files                  824      831       +7     
  Lines                37914    38320     +406     
  Branches              4318     4371      +53     
===================================================
  Hits                  4085     4085              
- Misses               33634    34040     +406     
  Partials               195      195              
Impacted Files Coverage Δ
.../com/sk89q/worldedit/sponge/CUIChannelHandler.java 0.00% <0.00%> (ø)
...ava/com/sk89q/worldedit/sponge/CommandAdapter.java 0.00% <0.00%> (ø)
...ain/java/com/sk89q/worldedit/sponge/Constants.java 0.00% <0.00%> (ø)
...java/com/sk89q/worldedit/sponge/SpongeAdapter.java 0.00% <0.00%> (ø)
...om/sk89q/worldedit/sponge/SpongeBiomeRegistry.java 0.00% <0.00%> (ø)
.../worldedit/sponge/SpongeBlockCategoryRegistry.java 0.00% <0.00%> (ø)
...om/sk89q/worldedit/sponge/SpongeBlockMaterial.java 0.00% <0.00%> (ø)
...om/sk89q/worldedit/sponge/SpongeBlockRegistry.java 0.00% <0.00%> (ø)
...om/sk89q/worldedit/sponge/SpongeCommandSender.java 0.00% <0.00%> (ø)
.../java/com/sk89q/worldedit/sponge/SpongeEntity.java 0.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab61a84...ac8ac86. Read the comment docs.

@octylFractal octylFractal force-pushed the feature/sponge-8-attempt-2 branch from 153b43f to 706770b Compare June 5, 2021 00:15
@octylFractal octylFractal removed this from the 7.2.6 milestone Jul 29, 2021
@octylFractal octylFractal force-pushed the feature/sponge-8-attempt-2 branch from 706770b to 3d69c85 Compare September 10, 2021 07:44
@me4502 me4502 force-pushed the feature/sponge-8-attempt-2 branch from 3d69c85 to f828f76 Compare September 10, 2021 07:51
@me4502 me4502 force-pushed the feature/sponge-8-attempt-2 branch from 604ef7e to 4555236 Compare January 7, 2022 06:53
@me4502 me4502 marked this pull request as ready for review January 9, 2022 02:59
@me4502 me4502 changed the title [WIP] Sponge 8, Attempt 2 Update worldedit-sponge to API 8 Jan 9, 2022
@me4502
Copy link
Member

me4502 commented Jan 11, 2022

Partially blocked by SpongePowered/Sponge#3585 (Unsure if acceptable to merge before this is fixed) Resolved by Sponge

Copy link
Member

@me4502 me4502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my look-overs and testing this appears to be good, aside from otherwise noted external issues

@octylFractal octylFractal enabled auto-merge (squash) January 29, 2022 17:39
@octylFractal octylFractal merged commit fb50324 into version/7.2.x Jan 29, 2022
@octylFractal octylFractal deleted the feature/sponge-8-attempt-2 branch January 29, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:sponge Specific to the Sponge platform status:accepted Will be fixed / added to WorldEdit, eventually type:feature-request Request for something new
Projects
Development

Successfully merging this pull request may close these issues.

3 participants