[script] Script for querying all reports #4245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
force-pushed
the
query_checkers_script
branch
6 times, most recently
from
1893732 to
5179211
Compare
cservakt
reviewed
Aug 2, 2024
| def result_getter(args: argparse.Namespace): | ||
| def get_results(product_run: Tuple[str, str]): | ||
| product, run = product_run | ||
| print(product, run) |
There was a problem hiding this comment.
Is it necessary to print these values here?
Comment on lines
+106
to
+111
| for product in args.products: | ||
| f = functools.partial(lambda p, r: (p, r), product) | ||
| with subprocess.Popen([ | ||
| 'CodeChecker', 'cmd', 'runs', | ||
| '--url', f'{args.url}/{product}', | ||
| '-o', 'json'], | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE | ||
| ) as proc: | ||
| runs = list(__get_keys_from_list(proc.stdout.read())) | ||
|
|
||
| with Pool(args.jobs) as p: | ||
| p.map(result_getter(args), map(f, runs)) |
There was a problem hiding this comment.
I am just wondering wouldn't be better to have this section in a helper function.
Comment on lines
30
to
50
| result1 = json.load(args.result1) | ||
| result2 = json.load(args.result2) | ||
|
|
||
| result1.sort(key=lambda report: report['bugHash'] + str(report['reportId'])) | ||
| result2.sort(key=lambda report: report['bugHash'] + str(report['reportId'])) | ||
|
|
||
| found_mismatch = False | ||
|
|
||
| for report in result1: | ||
| if report not in result2: | ||
| print("Report not found in result2:") | ||
| print(json.dumps(report, indent=4)) | ||
| found_mismatch = True | ||
|
|
||
| for report in result2: | ||
| if report not in result1: | ||
| print("Report not found in result1:") | ||
| print(json.dumps(report, indent=4)) | ||
| found_mismatch = True | ||
|
|
||
| args.result1.close() | ||
| args.result2.close() |
There was a problem hiding this comment.
I think there is a code duplication here. Could you create a function to avoid it?
bruntib
force-pushed
the
query_checkers_script
branch
from
5179211 to
9efaf77
Compare
This script can query all reports for all products from a CodeChecker server.
bruntib
force-pushed
the
query_checkers_script
branch
from
9efaf77 to
591495c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script can query all reports for all products from a CodeChecker server.