Skip to content

additional library was required for venv_dev #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

stt08
Copy link
Collaborator

@stt08 stt08 commented Jun 24, 2024

Solution was found on https://stackoverflow.com/a/14424226

The documentation should contain libpq-dev dependency

FIXES #4258

@stt08 stt08 requested a review from dkrupp as a code owner June 24, 2024 14:11
@whisperity
Copy link
Contributor

The guide in the README is for venv, not venv_dev. I don't think we should force dependencies on users that only want to use CodeChecker, as per following the guide, that are not required for the proper function of the deployment package.

@whisperity whisperity added dev env ⛑️ Development environment documentation 📖 Changes to documentation. labels Jun 25, 2024
@dkrupp
Copy link
Member

dkrupp commented Aug 14, 2024

The guide in the README is for venv, not venv_dev. I don't think we should force dependencies on users that only want to use CodeChecker, as per following the guide, that are not required for the proper function of the deployment package.

The document is also about venv_dev see this note above:
# NOTE: if you want to develop CodeChecker, use the venv_dev` target instead

of venv.`

So I think we could extend the note with this

In case of venv_dev and Ubuntu 23, install an additional library:

Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention that this extra dependency is only needed for venv_dev

@dkrupp dkrupp merged commit 91b729c into Ericsson:master Oct 21, 2024
8 checks passed
@stt08 stt08 deleted the fix-venv_dev branch October 21, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev env ⛑️ Development environment documentation 📖 Changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

venv_dev is not created on Ubuntu 23
3 participants