Implementation of Oauth of Github, Google and Microsoft #4298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feyruzb
force-pushed
the
branch-2-backup
branch
2 times, most recently
from
5ce7f18 to
68eaf7b
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
2 times, most recently
from
de2e213 to
d3f6b29
Compare
vodorok
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Please see my remarks.
I have some additional comments apart from the direct in code messages:
- My major concern with the implementation is that the oauth related API and its implementation is not generalized enough. The configuration is good enough for the time being.
- I am not sure if we are allowed to use the Git Hub logo in our repo.
- Please invite @cservakt to review the JS and VueJS parts.
I did not do a thorough review of the oauth flow in authentication.py after you addressed the above issues I will do another round concentrating on that.
Thanks for the hard work!
feyruzb
force-pushed
the
branch-2-backup
branch
10 times, most recently
from
12c68e7 to
f064c2b
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
3 times, most recently
from
b4d5a0a to
d3847d6
Compare
…s, commented lines
feyruzb
force-pushed
the
branch-2-backup
branch
9 times, most recently
from
1f09f7c to
9d7d0c7
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
from
9d7d0c7 to
b15f48a
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
4 times, most recently
from
a990318 to
d98ca60
Compare
feyruzb
force-pushed
the
branch-2-backup
branch
from
d98ca60 to
4b2f8ff
Compare
bruntib
reviewed
Mar 25, 2025
| match = pattern.match(callback_url) | ||
| if match is None: | ||
| LOG.warning("Configuration format of callback_url is " | ||
| f"invalid for provider {provider_name}." |
There was a problem hiding this comment.
Add an extra space to the end so the next sentence is separate.
Also, this message should be printed only if the given provider is enabled.
web/server/config/server_config.json
Outdated
| "client_id" : "ExampleClientID", | ||
| "client_secret": "ExampleClientSecret", | ||
| "authorization_url": "https://github.com/login/oauth/authorize", | ||
| "callback_url": "http://server_host/login/OAuthLogin/provider", |
There was a problem hiding this comment.
Suggest https. A the other providers, too.
feyruzb
force-pushed
the
branch-2-backup
branch
2 times, most recently
from
8b078c0 to
7f39ebe
Compare
…ck_url, removed unnecessary code from fetching token
feyruzb
force-pushed
the
branch-2-backup
branch
from
7f39ebe to
b9f7f40
Compare
bruntib
approved these changes
Mar 26, 2025
feyruzb
force-pushed
the
branch-2-backup
branch
from
bcd1da8 to
3cc379b
Compare
vodorok
approved these changes
Mar 28, 2025
Discookie
approved these changes
Mar 28, 2025
bruntib
dismissed
dkrupp’s stale review
Based on personal agreement the PR can be merged for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4160
The right way it should look after logging in
new added button to log in with github
Changes: