Adding a --drop-reports-from-skipped-files parameter to analyze #4332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkrupp
added
WIP 💣
dkrupp
force-pushed
the
ctu_singlefile2
branch
from
71a915a to
b92a225
Compare
dkrupp
changed the title
dkrupp
force-pushed
the
ctu_singlefile2
branch
3 times, most recently
from
bcb62bd to
9bfd59c
Compare
The report filtering post processing step was removed as part of the --skip SKIPFILE parameter and was separated out to a --drop-reports-from-skipped-files paramer. This way the reports are not skipped as a post processing step by default. With the argument set to true the legacy behaviour is triggered that is all reports from the files which are skipped from the analysis are dropped.
dkrupp
force-pushed
the
ctu_singlefile2
branch
from
9bfd59c to
6971859
Compare
bruntib
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default CodeChecker used to filter out all reports from files which were on the skip list. This can hide true positive reports strating from unskipped code and endingin skipped files (typical with CTU and header related findings).
This patch removes the default report filtering post processing step from CodeChecker analyze --skip SKIPFILE operation.
The legacy functionality is still available with the --drop-reports-from-skipped-files paramer.
This way the reports are not skipped as a post processing step by default.