-
Notifications
You must be signed in to change notification settings - Fork 408
[feat] Introduce cc-verbatim-args-file #4456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 343acd9.
da4d47d
to
9d76eca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the description of these options in the analyzer specific configuration guide too
https://github.com/Ericsson/codechecker/blob/master/docs/analyzer/checker_and_analyzer_configuration.md
And rename the document from " Configuring Clang Static Analyzer and checkers" to "Configuring analyzers and checkers" (I know this would be an unrelated change, but still..
return [] | ||
return [ | ||
('cc-verbatim-args-file', | ||
'A file path containing flags that are forwarded verbatim to the ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mention the expected parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config file is accepted even though the verbatim-args-file does not exist:
--analyzer-config clangsa:cc-verbatim-args-file=./saargs.tx
Please return with an error in this case.
The `--saargs`, `--tidyargs` and `--cppcheckargs` files are now deprecated. These config files can now be provided through `--analyzer-config` flag with a common config named `cc-verbatim-args-file`.
9d76eca
to
cf42610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
--saargs
,--tidyargs
and--cppcheckargs
files are nowdeprecated. These config files can now be provided through
--analyzer-config
flag with a common config namedcc-verbatim-args-file
.