Skip to content

[feat] Introduce cc-verbatim-args-file #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

bruntib
Copy link
Contributor

@bruntib bruntib commented Feb 12, 2025

The --saargs, --tidyargs and --cppcheckargs files are now
deprecated. These config files can now be provided through
--analyzer-config flag with a common config named
cc-verbatim-args-file.

@bruntib bruntib added this to the release 6.25.0 milestone Feb 12, 2025
@bruntib bruntib requested a review from cservakt February 12, 2025 09:56
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the description of these options in the analyzer specific configuration guide too
https://github.com/Ericsson/codechecker/blob/master/docs/analyzer/checker_and_analyzer_configuration.md

And rename the document from " Configuring Clang Static Analyzer and checkers" to "Configuring analyzers and checkers" (I know this would be an unrelated change, but still..

return []
return [
('cc-verbatim-args-file',
'A file path containing flags that are forwarded verbatim to the '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention the expected parameter

Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config file is accepted even though the verbatim-args-file does not exist:
--analyzer-config clangsa:cc-verbatim-args-file=./saargs.tx
Please return with an error in this case.

The `--saargs`, `--tidyargs` and `--cppcheckargs` files are now
deprecated. These config files can now be provided through
`--analyzer-config` flag with a common config named
`cc-verbatim-args-file`.
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkrupp dkrupp merged commit 7cc9b9e into Ericsson:master Feb 25, 2025
7 of 8 checks passed
@bruntib bruntib deleted the verbatim_args branch February 26, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants