Skip to content

[feat] Display announcement message in the CLI #4535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

noraz31
Copy link
Collaborator

@noraz31 noraz31 commented Apr 16, 2025

When an announcement message is displayed on the GUI, it will be displayed in the CLI as well whenever the CodeChecker cmd login command is used.

@noraz31 noraz31 requested review from bruntib and vodorok as code owners April 16, 2025 12:38
@noraz31 noraz31 requested review from dkrupp and cservakt April 16, 2025 13:03
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a testcase for this?

@noraz31 noraz31 force-pushed the cli_announcement_display branch from 24b24f1 to 4be03f6 Compare April 23, 2025 09:39
@noraz31 noraz31 marked this pull request as draft April 23, 2025 09:39
@noraz31 noraz31 force-pushed the cli_announcement_display branch 3 times, most recently from 69a0a32 to 38bae10 Compare April 23, 2025 11:39
@noraz31 noraz31 marked this pull request as ready for review April 23, 2025 11:56
@noraz31
Copy link
Collaborator Author

noraz31 commented Apr 23, 2025

Could you please add a testcase for this?

Sure, added a testcase

@noraz31 noraz31 requested a review from dkrupp April 23, 2025 11:57
When an announcement message is displayed on the GUI, it will be
displayed in the CLI as well whenever the CodeChecker cmd login
command is used.
@noraz31 noraz31 force-pushed the cli_announcement_display branch from 38bae10 to 12fe7bc Compare April 28, 2025 08:16
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkrupp dkrupp merged commit 95821d9 into Ericsson:master Apr 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants