Skip to content

Simplify oauth interface #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

Simplify oauth interface #4539

merged 3 commits into from
Apr 17, 2025

Conversation

gulyasgergely902
Copy link
Collaborator

What have been done:

  • If only one oauth provider exists the SSO button reads "Login with " and without opening the modal redirects straight to the provider login page on click. If more than one exists, the standard SSO Login opens on click with the modal to choose the desired provider.

dkrupp
dkrupp approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkrupp dkrupp merged commit 12c0c04 into Ericsson:master Apr 17, 2025
8 checks passed
@gulyasgergely902 gulyasgergely902 deleted the simplify-oauth-interface branch May 5, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkrupp dkrupp dkrupp approved these changes

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

@vodorok vodorok Awaiting requested review from vodorok vodorok is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gulyasgergely902 @dkrupp