Skip to content

remove EXV_SEPARATOR #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

remove EXV_SEPARATOR #3213

wants to merge 1 commit into from

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Mar 14, 2025

No need with std::filesystem

No need with std::filesystem

Signed-off-by: Rosen Penev <[email protected]>
@neheb neheb requested a review from kmilos March 14, 2025 20:20
@kmilos
Copy link
Collaborator

kmilos commented Mar 17, 2025

I really don't know what to think about std::filesystem any more, and whether it's a good idea to proliferate its use:

https://stackoverflow.com/questions/57603013/how-to-safely-convert-const-char-to-const-char8-t-in-c20

@neheb
Copy link
Collaborator Author

neheb commented Mar 17, 2025

Not sure how that applies here?

Copy link
Member

@tbeu tbeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems related to #3195.

@neheb
Copy link
Collaborator Author

neheb commented Mar 30, 2025

Sure. I’ve been taking commits out of there and putting them as separate PRs to get them merged.

@neheb
Copy link
Collaborator Author

neheb commented Apr 3, 2025

merged.

@neheb neheb closed this Apr 3, 2025
@neheb neheb deleted the 4 branch April 3, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants