Skip to content

[BUG]: Initial value of FilterQuality in flutter_gen is different from Flutter(since ver 3.24.0)'s default value. #598

Closed
@yamashita-room-335

Description

@yamashita-room-335

Is there an existing issue for this?

  • I have searched the existing issues

Version

5.8.0

Command type

build_runner (Default)

What happened?

In the image() method generated by Flutter Gen, the initial value of FilterQuality is FilterQuality.low, but in the Image() method of the Flutter SDK from Flutter 3.24.0, the initial value of filterQuality is FilterQuality.medium.

Details: Flutter Official Release Notes -> 3.24.0 announcement

It would be great if you could add a modification to follow the value of the Flutter SDK.

assets.gen.dart in the flutter_gen generated file

class AssetGenImage {
  ~~~
  Image image({
    ~~~
    FilterQuality filterQuality = FilterQuality.low,
    ~~~
  }) {
    return Image.asset(
      ~~~
      filterQuality: filterQuality,
      ~~~
    );
  }
  ~~~
}

image.dart in the Flutter SDK

  Image.asset(
    String name, {
    super.key,
    AssetBundle? bundle,
    ~~~
    this.filterQuality = FilterQuality.medium,
    ~~~
  }) : image = ResizeImage.resizeIfNeeded(
         cacheWidth,
         cacheHeight,
         scale != null
           ? ExactAssetImage(name, bundle: bundle, scale: scale, package: package)
           : AssetImage(name, bundle: bundle, package: package),
       ),
       loadingBuilder = null,
       assert(cacheWidth == null || cacheWidth > 0),
       assert(cacheHeight == null || cacheHeight > 0);

As an aside, the link to the “Code of Conduct” of the create "Issue: Bug Report" page seems to be a 404.

Relevant a pubspec.yaml.

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions