Skip to content

feat: Add single and multiple code pane layouts #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 6, 2022
Merged

Conversation

ZimChristine
Copy link
Contributor

Description

The changes in this PR add two new slide layouts for easily adding a code with syntax highlighting and a title. There are two slide layouts:

  1. a single code pane with optional title
  2. multiple code panes with optional descriptions and an optional title

Type of Change

  • [ x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Jest tests have been added for the feature.
  • During development the feature was manually tested by consuming the new SlideLayouts in the example tsx app.

Checklist:

  • [ x ] I have included a changeset if this change will require a version change to one of the packages.
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the api documentation
  • [ x ] I have run pnpm run check:ci and all checks pass
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • [ x ] My changes generate no new warnings
  • [ na ] Any dependent changes have been merged and published in downstream modules

@ZimChristine ZimChristine requested a review from gksander August 31, 2022 17:31
@github-actions github-actions bot temporarily deployed to staging-1217 August 31, 2022 17:35 Inactive
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, I can't wait to use this! A couple little suggestions here.

@github-actions github-actions bot temporarily deployed to staging-1217 September 1, 2022 22:46 Inactive
@github-actions github-actions bot temporarily deployed to staging-1217 September 6, 2022 21:16 Inactive
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 LGTM

@github-actions github-actions bot temporarily deployed to staging-1217 September 6, 2022 21:17 Inactive
@github-actions github-actions bot had a problem deploying to staging-1217 September 6, 2022 21:18 Failure
@ZimChristine ZimChristine merged commit cdc0afe into main Sep 6, 2022
@ZimChristine ZimChristine deleted the codePane-layout branch September 6, 2022 22:10
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants