test(consistency): aux database consistency in integ tests #2874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
fix/consistency-in-integ-tests
branch
from
2badd5a to
00c4b6b
Compare
rymnc
force-pushed
the
fix/consistency-in-integ-tests
branch
from
00c4b6b to
2ef1aab
Compare
xgreenx
reviewed
Mar 18, 2025
| } | ||
| } | ||
|
|
||
| if let Some(latest_height) = latest_height { |
There was a problem hiding this comment.
I think it will be better if GasPriceService provided a way to wait until block height X, like Relayer or OffChainWorker do.
We have several tests that could be more stable if we had this functionality.
|
closing in favour of implementing an await_until_synced method on the gas price service |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
Enforces consistency of all databases in the
consistencyfnChecklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]