Skip to content

feat: fix install script mime type #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

feat: fix install script mime type #713

merged 1 commit into from
Mar 18, 2025

Conversation

mchristopher
Copy link
Member

Adding a Cloudflare Worker which will re-write the Content-Type HTTP header with the correct MIME type for a shell script.

This is needed since GitHub pages doesn't support overriding the MIME type of a file, and the only "index" file that is supported must end in .html (which automatically gets the type text/html).

@mchristopher mchristopher requested a review from a team March 17, 2025 21:41
Copy link
Contributor

LCOV of commit daf70ed during CI #2153

Summary coverage rate:
  lines......: 85.6% (2423 of 2832 lines)
  functions..: 54.0% (334 of 619 functions)
  branches...: 63.0% (290 of 460 branches)

Files changed coverage rate: n/a

Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JoshuaBatty JoshuaBatty merged commit 5cbf9fe into master Mar 18, 2025
18 checks passed
@JoshuaBatty JoshuaBatty deleted the cf-worker branch March 18, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants