Skip to content

[CHORE] Null safety for 5 more classes #4751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

[CHORE] Null safety for 5 more classes #4751

wants to merge 18 commits into from

Conversation

Lasercar
Copy link
Contributor

A small contribution towards #4303

Null safety added to

Highscore
InitState (Partial)
Paths
PlayerSettings (Partial)
Preferences

ninjamuffin99 and others added 18 commits April 1, 2025 16:41
@ninjamuffin99
easier script for creating macos universal binaries
4fa0334
@EliteMasterEric @ninjamuffin99
Fix an issue where story mode medals would not be awarded without a p…
54cd52d 
…ersonal best.
@EliteMasterEric @ninjamuffin99
Fix highscores not submitting to the website unless they are a person…
17a4be6 
…al best.
@EliteMasterEric @ninjamuffin99
Fix a deprecation warning.
3bd79b8
@EliteMasterEric @ninjamuffin99
Improve null safety of medal and leaderboard classes.
f8b212a
@EliteMasterEric @ninjamuffin99
Fix a bug where restarting the level would add more Tankmen to the ba…
102ac4b 
…ckground.
@EliteMasterEric @ninjamuffin99
Update assets submodule
f935526
@EliteMasterEric @ninjamuffin99
Make the back of ABot's stereo display slightly wider.
8291fe0
@ninjamuffin99
2024 -> 2025 0.6.x changelog date fixins (closes FUNK-1740)
c94b3a3
@ninjamuffin99
Auto Pause -> Pause on Unfocus (was changed before but prob bad merge…
52be941 
… somewhere reverted it?)
@ninjamuffin99
data -> data.score
6262188
@ninjamuffin99
quick patch for cory
9b5032e
@EliteMasterEric @ninjamuffin99
Remove some unused/redundant debug hotkeys.
afb4a3d
@EliteMasterEric @ninjamuffin99
Fix Pixo's freeplay AFK animation not playing (properly this time).
eb9c2c2
@EliteMasterEric @ninjamuffin99
Fix certain characters pixel icons not displaying properly in the cha…
c157338 
…rt editor.
@EliteMasterEric @ninjamuffin99
Zero out the ABot visualizer before the song starts.
68e9daf
@EliteMasterEric
Use public submodule URLs (would be nice if this was automatic but oh…
d31ef12 
… well)
@Lasercar
funkin null safe
a4870af
@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed size: medium A medium pull request with 100 or fewer changes. labels Apr 18, 2025
@AbnormalPoof AbnormalPoof added size: medium A medium pull request with 100 or fewer changes. type: chore Involves minor adjustments that do not make functional changes. labels Apr 18, 2025
@Lasercar Lasercar changed the title Chore: Funkin null safe [CHORE] Null safety for 5 more classes Apr 18, 2025
Hundrec
Hundrec reviewed Apr 20, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine!

Hundrec
Hundrec approved these changes Apr 20, 2025
View reviewed changes
Copy link
Collaborator

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hundrec Hundrec Hundrec approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: chore Involves minor adjustments that do not make functional changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lasercar @Hundrec @AbnormalPoof @ninjamuffin99 @EliteMasterEric