[CHORE] Add null-safety to 5 classes in funkin.play
#4788
+91
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A contribution towards #4303.
This PR adds null-safety to:
Countdown
PauseSubState
GitarooPause
ResultScore
ScoreNum
Because
GameoverSubState
,ResultState
, andPlayStatePlaylist
are already null-safe, this PR makes it so almost all basefunkin.play
classes have null-safety. The last one would bePlayState
. (That file is over 3000 lines long, so it would probably need its own dedicated PR)(Even though
PlayState
isn't null-safe yet, I still added checks for its values inCountdown
andPauseSubState
)Some Notes for
ResultScore
andScoreNum
In
ResultScore
, there was a variable initialized without a value, but it was unused except in commented-out code, so I removed it and the commented-out code associated with it.In
ScoreNum
, there were two public variables initialized without a value (aFlxTimer
and aFlxTween
), but they were only ever referred to once in the class and no other classes accessed these variables. This meant I could safely remove these variables and set theFlxTimer
andFlxTween
by themselves instead.