[CHORE] Add null-safety to registries and 5 other classes funkin.data
#4798
+40
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A contribution towards #4303.
This PR adds null-safety to all registries in
funkin.data
(SongRegistry
already has null-safety). These include:BaseRegistry
ConversationRegistry
DialogueBoxRegistry
SpeakerRegistry
SongEventRegistry
AlbumRegistry
PlayerRegistry
FreeplayStyleRegistry
NoteStyleRegistry
StageRegistry
LevelRegistry
StickerRegistry
I also had to fix
Song.hx
because that file has null-safety, but was dependent onBaseRegistry
which wasn't null-safe.Aside from the registries, I included null-safety for some other classes in
funkin.data
too. These include:DataError
DataParse
DataWrite
AnimationData
SongDataUtils