Skip to content

[CHORE] Add null-safety to registries and 5 other classes funkin.data #4798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

VioletSnowLeopard
Copy link
Contributor

@VioletSnowLeopard VioletSnowLeopard commented Apr 25, 2025

A contribution towards #4303.

This PR adds null-safety to all registries in funkin.data (SongRegistry already has null-safety). These include:

  • BaseRegistry
  • ConversationRegistry
  • DialogueBoxRegistry
  • SpeakerRegistry
  • SongEventRegistry
  • AlbumRegistry
  • PlayerRegistry
  • FreeplayStyleRegistry
  • NoteStyleRegistry
  • StageRegistry
  • LevelRegistry
  • StickerRegistry

I also had to fix Song.hx because that file has null-safety, but was dependent on BaseRegistry which wasn't null-safe.

Aside from the registries, I included null-safety for some other classes in funkin.data too. These include:

  • DataError
  • DataParse
  • DataWrite
  • AnimationData
  • SongDataUtils

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. and removed status: pending triage Awaiting review. labels Apr 25, 2025
@AbnormalPoof AbnormalPoof added status: pending triage Awaiting review. type: chore Involves minor adjustments that do not make functional changes. labels Apr 25, 2025
@Lasercar
Copy link
Contributor

Just something to note, this'll have merge conflicts with 0.6.3, which to my understanding is being released... now

@Hundrec Hundrec self-requested a review April 29, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: chore Involves minor adjustments that do not make functional changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants