Skip to content

Long urls breaks table responsiveness #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GabLeRoux opened this issue Feb 8, 2018 · 2 comments
Closed

Long urls breaks table responsiveness #7

GabLeRoux opened this issue Feb 8, 2018 · 2 comments

Comments

@GabLeRoux
Copy link
Owner

image

I tried to add the following .break-all class:

.break-all {
word-break:break-all;
display: flex;
}

on the anchor tag here:

return '<a href="' + data + '" target="_blank">' + data + '</a>';

but the column width gets too small:

image

We should try to resize columns, maybe use something like jeffreydwalter/ColReorderWithResize (see it in action)

GabLeRoux added a commit that referenced this issue Feb 8, 2018
Note: this introduces an issue when resizing columns where contents gets
removed or replaced randomly. Maybe it's broken or there's something
wrong with recent versions of dataTable :(
@GabLeRoux
Copy link
Owner Author

As explained in 1642c50 message

Note: this introduces an issue when resizing columns where contents gets
removed or replaced randomly. Maybe it's broken or there's something
wrong with recent versions of dataTable :(

We need to find a fix for the data disappearing when using jeffreydwalter/ColReorderWithResize or find another solution.

@GabLeRoux
Copy link
Owner Author

Oh nervermind, it works as expected. Problem happens when we actually click the header. It was due to column ordering which was totally confusing me.

So maybe we should find a way to order columns only by clicking the ordering icon and not the whole header. I'm ok with that 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant