Skip to content

[gdb] Fix gdb.attach() for several use cases #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 21, 2020
Merged

[gdb] Fix gdb.attach() for several use cases #1590

merged 8 commits into from
Jun 21, 2020

Conversation

heapcrash
Copy link
Collaborator

@heapcrash heapcrash commented Jun 19, 2020 •
edited
Loading

  • sock-based GDB connections didn't set the PID, so it didn't work
    • Now uses a real Timeout object
    • Added special case handling for socat, since we were attaching to the wrong process
  • ssh-based doctests improved
    • Works locally on everything I tested
    • One test is ignored, since it doesnt work on Travis CI
  • run_in_new_terminal supports unicode strings now
    • This fixes SSH-based debugging
  • wait_for_debugger now has a timeout
    • Fixes the case where the debugger never comes up, mostly for tests

Fixes #1589

@heapcrash heapcrash force-pushed the remote-debugging branch 4 times, most recently from 8b6b621 to 3a9a04f Compare June 20, 2020 03:10
@heapcrash heapcrash changed the title [gdb] Tests seem not to be running, since the socat example is broken [gdb] Fix gdb.attach() for several use cases Jun 20, 2020
@heapcrash heapcrash requested a review from Arusekk June 20, 2020 03:13
@heapcrash heapcrash force-pushed the remote-debugging branch 6 times, most recently from 0f42e30 to 0afc06b Compare June 20, 2020 21:45
@heapcrash heapcrash changed the base branch from dev to stable June 20, 2020 21:45
@heapcrash heapcrash force-pushed the remote-debugging branch 6 times, most recently from b3c3594 to 3bfaa46 Compare June 20, 2020 23:11
heapcrash added 2 commits June 20, 2020 18:13
@heapcrash
[gdb] Fix automatic debugging for listen, remote, and ssh
4aae933 
* sock-based GDB connections didn't set the PID, so it didn't work
  * Now uses a real Timeout object
  * Added special case handling for socat, since we were attaching to the wrong process
* ssh-based doctests improved
  * Works locally on everything I tested
  * One test is ignored, since it doesnt work on Travis CI
  * Added libc6-dbg to Github Actions
* run_in_new_terminal supports unicode strings now
  * This fixes SSH-based debugging
* wait_for_debugger now has a timeout
  * Fixes the case where the debugger never comes up, mostly for tests
@heapcrash
[ci] Backport CI scripts from dev branch
ec08924
@heapcrash heapcrash merged commit e8b4f0b into Gallopsled:stable Jun 21, 2020
@heapcrash heapcrash deleted the remote-debugging branch June 21, 2020 00:41
@heapcrash heapcrash mentioned this pull request Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arusekk Arusekk Awaiting requested review from Arusekk

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Magic gdb.attach(remote) debugging is broken
2 participants
@heapcrash @Arusekk