Fix process() with executable relative to cwd #1751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mephi42
changed the title
|
Please add a doctest that ensures this works with absolute paths too. Great stuff, thanks! |
mephi42
force-pushed
the
executable-relative-to-cwd
branch
from
3fb9b4e to
a820d85
Compare
|
Thanks for reviewing :-) Not sure, which exact combination you had in mind, so I added 3 more that I could think of. |
mephi42
force-pushed
the
executable-relative-to-cwd
branch
from
a820d85 to
4b99a1f
Compare
|
The tests have mysterious failures again. This is really unnerving of whatever on earth is causing this. Not your fault I hope :) EDIT: Aaaah, this is us wgetting some elderly gdbserver from Ubuntu's ftp (why the heck?). Yeah, the tests won't probably auto-run until someone fixes that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
process('./baz', cwd='foo/bar'), even whenfoo/bar/bazexists, throws an unhelpfulpwnlib.exception.PwnlibException: None does not exist. Fix by adding a special case to_validate().Testing
Added a new doctest to
pwnlib/tubes/process.py.Target Branch
devChangelog
Updated.