Skip to content

Fix adb.partitions listing #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2016
Merged

Fix adb.partitions listing #802

merged 3 commits into from
Dec 14, 2016

Conversation

zachriggle
Copy link
Member

The code for listing partitions was broken.

@zachriggle zachriggle added this to the 3.2.0 milestone Nov 30, 2016
@TethysSvensson
Copy link
Contributor

Do we have tests for this?

@zachriggle
Copy link
Member Author

zachriggle commented Dec 1, 2016 •
edited
Loading

Unfortunately, tests aren't possible because the emulator does not follow this partition scheme.

>>> adb.devices()
(AdbDevice(serial='emulator-5554', type='device', port='emulator', product='sdk_phone_armv7', model='sdk phone armv7', device='generic'),)
>>> list(adb.partitions)
[*] Enabling root on emulator-5554
[]

@zachriggle zachriggle merged commit eaf6402 into Gallopsled:stable Dec 14, 2016
@zachriggle zachriggle deleted the fix-partitions branch December 14, 2016 21:38
TethysSvensson
TethysSvensson reviewed Dec 24, 2016
View reviewed changes
Copy link
Contributor

@TethysSvensson TethysSvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TethysSvensson TethysSvensson TethysSvensson left review comments

Assignees

@TethysSvensson TethysSvensson

Labels
backport-complete bug
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zachriggle @TethysSvensson