CI: Upload the documentation PDF file as artifact for previewing #3837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
There was a problem hiding this comment.
PR Overview
This pull request adds a new CI step that uploads the generated documentation PDF as an artifact, allowing for easy previewing without rebuilding the docs manually.
- Added a step to upload the PDF artifact on push events with Ubuntu runners
- Retained the release asset upload step for both the HTML ZIP and PDF files
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/ci_docs.yml | Added new step for uploading the PDF as an artifact |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/ci_docs.yml:156
- [nitpick] Consider using consistent quotation marks for the event name condition to match the rest of the file, for example using single quotes for 'push'.
if: github.event_name == "push" && matrix.os == 'ubuntu-latest'
seisman
commented
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload the PDF file as artifact so that anyone can download the file and we don't have to build it ourselves just for previewing the changes.