-
Notifications
You must be signed in to change notification settings - Fork 13
feat(admin-ui): injecting env properties dynamically in admin-ui built #1720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
comp-admin-ui
Component affected by issue or PR
enhancement
New feature or request
kind-feature
Issue or PR is a new feature request
Comments
/admin-ui/config
(not from .env)
duttarnab
added a commit
that referenced
this issue
May 27, 2024
duttarnab
added a commit
that referenced
this issue
May 27, 2024
duttarnab
added a commit
that referenced
this issue
May 27, 2024
duttarnab
added a commit
that referenced
this issue
May 28, 2024
duttarnab
added a commit
that referenced
this issue
May 28, 2024
Signed-off-by: Arnab Dutta <[email protected]>
duttarnab
added a commit
that referenced
this issue
May 28, 2024
Signed-off-by: Arnab Dutta <[email protected]>
jv18creator
added a commit
that referenced
this issue
May 28, 2024
feat: injecting env properties dynamically in admin-ui built #1720
duttarnab
added a commit
that referenced
this issue
May 28, 2024
Signed-off-by: Arnab Dutta <[email protected]>
duttarnab
added a commit
that referenced
this issue
May 28, 2024
feat: injecting env properties dynamically in admin-ui built #1720
Reopening to remove BASE_PATH in env-config.js. It is essential to provide this property in .env so it cannot be altered using env-config.js. |
duttarnab
added a commit
that referenced
this issue
May 30, 2024
Signed-off-by: Arnab Dutta <[email protected]>
duttarnab
added a commit
that referenced
this issue
May 30, 2024
feat: injecting env properties dynamically in admin-ui built #1720
jv18creator
pushed a commit
that referenced
this issue
Jun 18, 2024
Signed-off-by: Arnab Dutta <[email protected]>
jv18creator
pushed a commit
that referenced
this issue
Jun 18, 2024
Signed-off-by: Arnab Dutta <[email protected]>
jv18creator
pushed a commit
that referenced
this issue
Jun 18, 2024
Signed-off-by: Arnab Dutta <[email protected]>
jv18creator
pushed a commit
that referenced
this issue
Jun 18, 2024
Signed-off-by: Arnab Dutta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp-admin-ui
Component affected by issue or PR
enhancement
New feature or request
kind-feature
Issue or PR is a new feature request
The VM/CN installer is not running the npm i or npm run api commands. Instead, it is taking the dependencies and OpenAPI client from https://jenkins.gluu.org/npm/admin_ui/main/, which are generated during the Jenkins build. I think we can have Jenkins create the admin-ui build and place it at https://jenkins.gluu.org/npm/admin_ui/**. This will remove the responsibility of Flex installers to run the npm run build:prod command and hence will solve the long build time problem.
<script src="/adminui-config.js" defer></script>
in/admin-ui/app/index.html
.The text was updated successfully, but these errors were encountered: