Skip to content

fix: inspect the cause of higher memory requirement in prod build creation #1243 #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2023
Merged

fix: inspect the cause of higher memory requirement in prod build creation #1243 #1257

merged 4 commits into from
Aug 11, 2023

Conversation

duttarnab
Copy link
Contributor

@duttarnab duttarnab commented Aug 4, 2023 •
edited
Loading

This PR addresses:

  • The unnecessary webpack configuration to divide the build into chunks.
  • The GZIP of the build is not useful as it also creates an unpacked build. Hence removed that configuration.

The memory requirement of the project has increased due to

  • upgrading node.js version from 14.x to 18.x
  • using of the redux toolkit

There is no way to reduce the memory requirement significantly.

closes #1243

@duttarnab duttarnab requested a review from syntrydy as a code owner August 4, 2023 16:58
@mo-auto mo-auto added comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Aug 4, 2023
@duttarnab duttarnab requested a review from jv18creator August 6, 2023 06:54
jv18creator
jv18creator suggested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@jv18creator jv18creator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check inline comment

@sonarqubecloud
Copy link

[flex_admin_ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jv18creator jv18creator merged commit 16e0f93 into main Aug 11, 2023
@jv18creator jv18creator deleted the admin-ui-issue-1243 branch August 11, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jv18creator jv18creator jv18creator approved these changes

@syntrydy syntrydy Awaiting requested review from syntrydy syntrydy is a code owner

Assignees
No one assigned
Labels
comp-admin-ui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(admin-ui): inspect the cause of higher memory requirement in prod build creation
3 participants
@duttarnab @jv18creator @mo-auto