Upcast int/float in long/double in sink #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashastia
reviewed
Feb 25, 2025
...ery/src/main/java/com/google/cloud/flink/bigquery/sink/serializer/AvroToProtoSerializer.java
Outdated
Show resolved
Hide resolved
prashastia
approved these changes
Feb 25, 2025
mina-asham
reviewed
Feb 25, 2025
Comment on lines
+128
to
+137
| return Long.valueOf(String.valueOf((int) element.getShort(fieldNumber))); | ||
| case INTEGER: | ||
| return Long.valueOf(String.valueOf(element.getInt(fieldNumber))); | ||
| case DATE: | ||
| // read in the form of - number of days since EPOCH (Integer) | ||
| return element.getInt(fieldNumber); | ||
| case BIGINT: | ||
| return element.getLong(fieldNumber); | ||
| case FLOAT: | ||
| return element.getFloat(fieldNumber); | ||
| return Double.valueOf(String.valueOf(element.getFloat(fieldNumber))); |
There was a problem hiding this comment.
Why are we converting to string then long/double here? Wouldn't this be super inefficient? Why not just cast the values? (long) element.getInt(...)
There was a problem hiding this comment.
Fair point. #222 looks good?
There was a problem hiding this comment.
Thank you for fixing this so quickly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219
/gcbrun