Skip to content

[Terraform] use cluster update for logging/monitoring in beta #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2018

Conversation

danawillow
Copy link
Contributor

@danawillow danawillow commented Dec 11, 2018

Fixes hashicorp/terraform-provider-google#2472


[all]

[terraform]

use cluster update for logging/monitoring in beta

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#205
depends: hashicorp/terraform-provider-google#2631

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 413ecb0) have been included in your existing downstream PRs.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm just curious why we can't use Update in GA as well?

@danawillow
Copy link
Contributor Author

The API doesn't support it: https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/ClusterUpdate (cmd-f for logging)

@rileykarson
Copy link
Member

Fair enough! Although we're still using the beta API at GA

Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants