-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added "endpointTypes" support to compute router nat resource #10338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "endpointTypes" support to compute router nat resource #10338
Conversation
Tests: - Added new test for "endpointTypes" field;
Supported values include: | ||
`ENDPOINT_TYPE_VM`, `ENDPOINT_TYPE_SWG`, | ||
`ENDPOINT_TYPE_MANAGED_PROXY_LB`. | ||
default_from_api: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Using "default_from_api" here since "default_value" does not support array values.
`ENDPOINT_TYPE_VM`, `ENDPOINT_TYPE_SWG`, | ||
`ENDPOINT_TYPE_MANAGED_PROXY_LB`. | ||
default_from_api: true | ||
item_type: Api::Type::String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a string type here instead of a enum (as the API specifies) to follow the same implementation used for the "sourceIpRangesToNat" field in this resource.
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
/gcbrun |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRouterNat_withEndpointTypes |
|
/gcbrun |
Tests analyticsTotal tests: Click here to see the affected service packages
|
looks like a stray error attempting to download a provider for unit tests. Let me rerun again. |
/gcbrun |
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Schema and tests look good to me.
Adds support for optional 'endpointTypes' field to 'google_compute_router_nat'
Fixes: hashicorp/terraform-provider-google#17001
Release Note Template for Downstream PRs (will be copied)