Skip to content

Added "endpointTypes" support to compute router nat resource #10338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matheusaleixo-cit
Copy link
Contributor

@matheusaleixo-cit matheusaleixo-cit commented Apr 1, 2024

Adds support for optional 'endpointTypes' field to 'google_compute_router_nat'

Fixes: hashicorp/terraform-provider-google#17001

Release Note Template for Downstream PRs (will be copied)

compute: added 'endpoint_types' field to 'google_compute_router_nat' resource

Supported values include:
`ENDPOINT_TYPE_VM`, `ENDPOINT_TYPE_SWG`,
`ENDPOINT_TYPE_MANAGED_PROXY_LB`.
default_from_api: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Using "default_from_api" here since "default_value" does not support array values.

`ENDPOINT_TYPE_VM`, `ENDPOINT_TYPE_SWG`,
`ENDPOINT_TYPE_MANAGED_PROXY_LB`.
default_from_api: true
item_type: Api::Type::String
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a string type here instead of a enum (as the API specifies) to follow the same implementation used for the "sourceIpRangesToNat" field in this resource.

@matheusaleixo-cit matheusaleixo-cit marked this pull request as ready for review April 1, 2024 19:46
@github-actions github-actions bot requested a review from c2thorn April 1, 2024 19:46
Copy link

github-actions bot commented Apr 1, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@c2thorn
Copy link
Member

c2thorn commented Apr 1, 2024

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-nat and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 1, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 132 insertions(+))
google-beta provider: Diff ( 3 files changed, 132 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 892
Passed tests: 819
Skipped tests: 72
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRouterNat_withEndpointTypes

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRouterNat_withEndpointTypes[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@c2thorn
Copy link
Member

c2thorn commented Apr 3, 2024

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 3, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 132 insertions(+))
google-beta provider: Diff ( 3 files changed, 132 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 892
Passed tests: 820
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@c2thorn
Copy link
Member

c2thorn commented Apr 3, 2024

looks like a stray error attempting to download a provider for unit tests. Let me rerun again.

@c2thorn
Copy link
Member

c2thorn commented Apr 3, 2024

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 3, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 132 insertions(+))
google-beta provider: Diff ( 3 files changed, 132 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 892
Passed tests: 820
Skipped tests: 72
Affected tests: 0

Click here to see the affected service packages
  • compute

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema and tests look good to me.

@matheusaleixo-cit matheusaleixo-cit deleted the add-endpoint-types-to-compute-router-nat branch April 4, 2024 20:23
sony-c pushed a commit to sony-c/magic-modules that referenced this pull request Apr 4, 2024
Gorlami96 pushed a commit to Gorlami96/magic-modules that referenced this pull request Apr 5, 2024
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing field endpoint-types for google_compute_router_nat resource
3 participants