Skip to content

[Terraform] add souce repo support to cloud functions #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

danawillow
Copy link
Contributor

@danawillow danawillow commented Dec 12, 2018

Fixes hashicorp/terraform-provider-google#1289.


[all]

[terraform]

add souce repo support to cloud functions

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#217
depends: hashicorp/terraform-provider-google#2650

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 8e882a4) have been included in your existing downstream PRs.

@danawillow danawillow changed the title [WIP] [Terraform] add souce repo support to cloud functions [Terraform] add souce repo support to cloud functions Dec 12, 2018
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 314d48f) have been included in your existing downstream PRs.

@modular-magician modular-magician force-pushed the tf-1289-cloud-functions-source branch from fb15891 to 2dd8560 Compare December 13, 2018 02:01
@modular-magician modular-magician merged commit 7b2135f into GoogleCloudPlatform:master Dec 13, 2018
@danawillow danawillow deleted the tf-1289-cloud-functions-source branch December 13, 2018 16:49
@susanjiang03
Copy link

susanjiang03 commented Apr 30, 2020

hello @danawillow, does this source repository url have to be hosted in google cloud source? can it be a github repository? thanks !

@danawillow
Copy link
Contributor Author

Yes, this resource is specifically for this product: https://cloud.google.com/source-repositories/

@susanjiang03
Copy link

Yes, this resource is specifically for this product: https://cloud.google.com/source-repositories/

Thanks @danawillow ! it would be great if we could use github repo.

@danawillow
Copy link
Contributor Author

Can you file a feature request at https://github.com/terraform-providers/terraform-provider-google? I don't think it makes sense to have a GCP source repository resource mean anything other than that specific product, but other resources we have support both GCP source repos and GitHub repos. It would be helpful to know exactly what your use case is- it's possible we already support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support deploying Cloud Functions from source control
5 participants