Skip to content

Dispatch MM unit test workflows based on modular-magician downstream SHAs #10671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 9, 2024
Merged

Dispatch MM unit test workflows based on modular-magician downstream SHAs #10671

merged 17 commits into from
Aug 9, 2024

Conversation

shuyama1
Copy link
Member

@shuyama1 shuyama1 commented May 12, 2024 •
edited
Loading

Following the Cloud Build Guide to pass upstream commit sha between build steps

fixes hashicorp/terraform-provider-google#17924

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@shuyama1 shuyama1 changed the title Test PR Dispatch MM unit test workflows based on modular-magician downstream SHAs May 12, 2024
@shuyama1 shuyama1 marked this pull request as draft May 12, 2024 07:24
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

shuyama1
shuyama1 commented May 13, 2024
View reviewed changes
.ci/magician/github/set.go Outdated
@@ -104,7 +104,7 @@ func (gh *Client) RemoveLabel(prNumber, label string) error {
func (gh *Client) CreateWorkflowDispatchEvent(workflowFileName string, inputs map[string]any) error {
url := fmt.Sprintf("https://api.github.com/repos/GoogleCloudPlatform/magic-modules/actions/workflows/%s/dispatches", workflowFileName)
err := utils.RequestCall(url, "POST", gh.token, nil, map[string]any{
"ref": "main",
"ref": "test-pr-10671",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for testing the updated tgc-test workflow in this PR. Will need to revert to "main" before merging.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@shuyama1 shuyama1 force-pushed the tgc_test branch 2 times, most recently from 05f3766 to b9d73bd Compare June 10, 2024 10:05
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

2 similar comments
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@shuyama1 shuyama1 marked this pull request as ready for review June 10, 2024 16:34
@shuyama1 shuyama1 requested a review from melinath June 10, 2024 16:34
melinath
melinath requested changes Jun 10, 2024
View reviewed changes
.github/workflows/test-tgc.yml Outdated
@@ -16,15 +16,21 @@ on:
description: 'The Base Repository to pull from'
required: false
default: 'terraform-google-conversion'
branch:
tpgb-branch:
description: 'The branch or sha of the tgc execute against'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'The branch or sha of the tgc execute against'
description: 'The branch or sha of tpgb execute against'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping on this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I modified the tpgb branch description. Will update it!

@shuyama1
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+))
google-beta provider: Diff ( 1 file changed, 2 insertions(+))

@shuyama1 shuyama1 requested a review from melinath June 12, 2024 15:14
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 29 insertions(+))
google-beta provider: Diff ( 3 files changed, 29 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_apigee_endpoint_attachment (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_apigee_endpoint_attachment" "primary" {
  test_field = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 41
Passed tests: 14
Skipped tests: 27
Affected tests: 0

Click here to see the affected service packages
  • apigee

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@shuyama1
Copy link
Member Author

shuyama1 commented Aug 9, 2024

@melinath I've reverted all the test-related changes. I plan to merge this PR later today unless there are any objections. Thanks for reviewing!

@shuyama1 shuyama1 merged commit 2d8923a into GoogleCloudPlatform:main Aug 9, 2024
7 checks passed
@shuyama1 shuyama1 deleted the tgc_test branch August 9, 2024 21:14
This was referenced Aug 9, 2024
Merged
Merged
Merged
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 12, 2024
@shuyama1 @rainshen49
Dispatch MM unit test workflows based on modular-magician downstream …
aa85fe9 
…SHAs (GoogleCloudPlatform#10671)
BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024
@shuyama1 @BBBmau
Dispatch MM unit test workflows based on modular-magician downstream …
a8209fd 
…SHAs (GoogleCloudPlatform#10671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

Assignees
No one assigned
Labels
service/apigee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dispatch MM unit test workflows based on modular-magician downstream SHAs instead of branches
3 participants
@shuyama1 @modular-magician @melinath