-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Prevent Dataflow options in parameters #11153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Dataflow options in parameters #11153
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
I tried to fix the formatting in the go.tmpl but editing in it is like using the old PC notepad as the IDE. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
As far as I can tell this won't make any changes to the provider until we switch over to using the new go-based mmv1. To make changes now you'd need to edit |
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 3 weeks. Please take a look! Use the label |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
46bceb6
to
18a396c
Compare
Hi @trodge Thank you for your help. I moved the changes over to the erb files. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 26 Click here to see the affected service packages
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 26 Click here to see the affected service packages
View the build log |
mmv1/third_party/terraform/services/dataflow/resource_dataflow_flex_template_job.go.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, except for one minor readability issue.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 26 Click here to see the affected service packages
View the build log |
@trodge All checks passed finally :-). Thank you for all your help. |
@trodge This is ready for your review. Thank you, again. |
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
A couple of tests started to fail in the nightly integration tests. Those tests were skipped in VCR and therefore the failures are not caught by presubmit tests in this PR. Newly Failing tests:
Need to revert this change for now. |
This PR throws more descriptive errors when users configure dataflow_flex_template_job or dataflow_job
parameters
with Dataflow options, as documented:do not configure Dataflow options here in parameters
.