Skip to content

Prevent Dataflow options in parameters #11153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Jul 12, 2024

This PR throws more descriptive errors when users configure dataflow_flex_template_job or dataflow_job parameters with Dataflow options, as documented: do not configure Dataflow options here in parameters.

dataflow: made provider return more descriptive errors when the `parameters` field of `google_dataflow_flex_template_job` contains Dataflow options

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge July 12, 2024 22:47
@damondouglas
Copy link
Contributor Author

I tried to fix the formatting in the go.tmpl but editing in it is like using the old PC notepad as the IDE.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge
Copy link
Contributor

trodge commented Jul 12, 2024

As far as I can tell this won't make any changes to the provider until we switch over to using the new go-based mmv1. To make changes now you'd need to edit mmv1/third_party/terraform/services/dataflow/resource_dataflow_flex_template_job.go.erb

Copy link

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Aug 2, 2024

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@trodge
Copy link
Contributor

trodge commented Aug 5, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@damondouglas damondouglas force-pushed the fix-dataflow-flex-template-job-streaming-engine-param branch from 46bceb6 to 18a396c Compare August 6, 2024 01:40
@damondouglas
Copy link
Contributor Author

As far as I can tell this won't make any changes to the provider until we switch over to using the new go-based mmv1. To make changes now you'd need to edit mmv1/third_party/terraform/services/dataflow/resource_dataflow_flex_template_job.go.erb

Hi @trodge Thank you for your help. I moved the changes over to the erb files.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 77 insertions(+), 52 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 77 insertions(+), 52 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link
Contributor

@trodge trodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, except for one minor readability issue.

@github-actions github-actions bot requested a review from trodge August 6, 2024 22:22
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 57 insertions(+), 52 deletions(-))

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • dataflow

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 56 insertions(+), 52 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@damondouglas
Copy link
Contributor Author

damondouglas commented Aug 7, 2024

@trodge All checks passed finally :-). Thank you for all your help.

@damondouglas
Copy link
Contributor Author

@trodge This is ready for your review. Thank you, again.

Copy link

github-actions bot commented Aug 9, 2024

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@trodge trodge merged commit 2897e86 into GoogleCloudPlatform:main Aug 9, 2024
11 checks passed
@damondouglas damondouglas deleted the fix-dataflow-flex-template-job-streaming-engine-param branch August 10, 2024 23:29
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 12, 2024
@shuyama1
Copy link
Member

A couple of tests started to fail in the nightly integration tests. Those tests were skipped in VCR and therefore the failures are not caught by presubmit tests in this PR.

Newly Failing tests:

  • TestAccDataflowFlexTemplateJob_FullUpdate
  • TestAccDataflowFlexTemplateJob_enableStreamingEngine
  • TestAccDataflowFlexTemplateJob_withProviderDefaultLabels

Need to revert this change for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants