-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Remove default_from_api
from liveness_probe
field in Cloud Run v2 service
#11190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default_from_api
from liveness_probe
field in Cloud Run v2 service
#11190
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@NickElliot Taking over this PR as I was reviewing the closed one. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. |
Tests analyticsTotal tests: 43 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
1d3de8b
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Fix hashicorp/terraform-provider-google#17468.
Cloud Run doesn't set a default value for liveness probe. Marking
liveness_probe
field withdefault_from_api: true
was a mistake.Release Note Template for Downstream PRs (will be copied)