Skip to content

Move bigqueryanalyticshub beta to v1 #11234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

obada-ab
Copy link
Contributor

@obada-ab obada-ab commented Jul 23, 2024

Move bigqueryanalyticshub beta to v1

b/347844459

Release Note Template for Downstream PRs (will be copied)


@github-actions github-actions bot requested a review from NickElliot July 23, 2024 09:00
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician modular-magician requested a review from wj-chen July 23, 2024 09:10
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3872
Passed tests: 3467
Skipped tests: 384
Affected tests: 21

Click here to see the affected service packages

All service packages are affected

Action taken

Found 21 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccBigqueryAnalyticsHubDataExchangeIamBindingGenerated
  • TestAccBigqueryAnalyticsHubDataExchangeIamMemberGenerated
  • TestAccBigqueryAnalyticsHubDataExchangeIamPolicyGenerated
  • TestAccBigqueryAnalyticsHubDataExchange_bigqueryAnalyticshubDataExchangeBasicExample
  • TestAccBigqueryAnalyticsHubListingIamBindingGenerated
  • TestAccBigqueryAnalyticsHubListingIamMemberGenerated
  • TestAccBigqueryAnalyticsHubListingIamPolicyGenerated
  • TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingBasicExample
  • TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingRestrictedExample
  • TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate
  • TestAccDataSourceArtifactRegistryDockerImage
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
  • TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigqueryAnalyticsHubDataExchangeIamBindingGenerated[Debug log]
TestAccBigqueryAnalyticsHubDataExchangeIamMemberGenerated[Debug log]
TestAccBigqueryAnalyticsHubDataExchangeIamPolicyGenerated[Debug log]
TestAccBigqueryAnalyticsHubDataExchange_bigqueryAnalyticshubDataExchangeBasicExample[Debug log]
TestAccBigqueryAnalyticsHubListingIamBindingGenerated[Debug log]
TestAccBigqueryAnalyticsHubListingIamMemberGenerated[Debug log]
TestAccBigqueryAnalyticsHubListingIamPolicyGenerated[Debug log]
TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingBasicExample[Debug log]
TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingRestrictedExample[Debug log]
TestAccBigqueryAnalyticsHubListing_bigqueryAnalyticshubListingUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@NickElliot
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician modular-magician requested a review from wj-chen July 29, 2024 21:07
Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per discussion any resources made with v1beta1 endpoint are fully compatible with the v1 endpoint, and with v1beta being deprecated in the future, service team wishes to move to using the v1 endpoint in Terraform, and verified compatibility via an upgrade test. LGTM!

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3879
Passed tests: 3483
Skipped tests: 385
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccDataSourceArtifactRegistryDockerImage
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
  • TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@NickElliot
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician modular-magician requested a review from wj-chen July 30, 2024 23:00
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3880
Passed tests: 3484
Skipped tests: 385
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccDataSourceArtifactRegistryDockerImage
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
  • TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from NickElliot July 31, 2024 09:14
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician modular-magician requested a review from wj-chen July 31, 2024 09:26
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3880
Passed tests: 3484
Skipped tests: 385
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccAppEngineStandardAppVersion_update
  • TestAccDataSourceArtifactRegistryDockerImage
  • TestAccIapAppEngineServiceIamBindingGenerated
  • TestAccIapAppEngineServiceIamBindingGenerated_withCondition
  • TestAccIapAppEngineServiceIamMemberGenerated
  • TestAccIapAppEngineServiceIamMemberGenerated_withCondition
  • TestAccIapAppEngineServiceIamPolicyGenerated
  • TestAccIapAppEngineServiceIamPolicyGenerated_withCondition
  • TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@NickElliot NickElliot merged commit 3e74944 into GoogleCloudPlatform:main Jul 31, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants