Added backupvault resource to Terraform backupdr product (beta) #11317

liyun-huang · 2024-07-31T20:17:52Z

`google_backup_dr_backup_vault` (beta)

github-actions · 2024-07-31T20:18:35Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-07-31T20:31:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 189 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 9 files changed, 1251 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 126 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_backup_vault (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_backup_vault" "primary" {
  annotations    = # value needed
  effective_time = # value needed
  labels         = # value needed
}

modular-magician · 2024-07-31T20:36:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 189 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 9 files changed, 1251 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 126 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_backup_vault (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_backup_vault" "primary" {
  annotations    = # value needed
  effective_time = # value needed
  labels         = # value needed
}

modular-magician · 2024-07-31T21:39:49Z

Tests analytics

Total tests: 3884
Passed tests: 3485
Skipped tests: 385
Affected tests: 14

Click here to see the affected service packages

All service packages are affected

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccBackupDRBackupVault_backupDrBackupVaultBasicExample

TestAccBackupDRBackupVault_update

TestAccDataSourceArtifactRegistryDockerImage

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccIapAppEngineServiceIamBindingGenerated

TestAccIapAppEngineServiceIamBindingGenerated_withCondition

TestAccIapAppEngineServiceIamMemberGenerated

TestAccIapAppEngineServiceIamMemberGenerated_withCondition

TestAccIapAppEngineServiceIamPolicyGenerated

TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

modular-magician · 2024-07-31T21:45:37Z

Tests analytics

Total tests: 3884
Passed tests: 3484
Skipped tests: 385
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccBackupDRBackupVault_backupDrBackupVaultBasicExample

TestAccBackupDRBackupVault_update

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

TestAccDataSourceArtifactRegistryDockerImage

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccIapAppEngineServiceIamBindingGenerated

TestAccIapAppEngineServiceIamBindingGenerated_withCondition

TestAccIapAppEngineServiceIamMemberGenerated

TestAccIapAppEngineServiceIamMemberGenerated_withCondition

TestAccIapAppEngineServiceIamPolicyGenerated

TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

modular-magician · 2024-07-31T22:00:42Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccBackupDRBackupVault_backupDrBackupVaultBasicExample[Error message] [Debug log]
TestAccBackupDRBackupVault_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-07-31T22:09:56Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccBackupDRBackupVault_backupDrBackupVaultBasicExample[Error message] [Debug log]
TestAccBackupDRBackupVault_update[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-08-01T15:50:24Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 210 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 9 files changed, 1400 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 126 insertions(+), 3 deletions(-))

modular-magician · 2024-08-01T16:59:08Z

Tests analytics

Total tests: 3886
Passed tests: 3485
Skipped tests: 385
Affected tests: 16

Click here to see the affected service packages

All service packages are affected

Action taken

Found 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccBackupDRBackupVault_backupDrBackupVaultBasicExample

TestAccBackupDRBackupVault_backupDrBackupVaultFullExample

TestAccBackupDRBackupVault_basicUpdate

TestAccBackupDRBackupVault_fullUpdate

TestAccDataSourceArtifactRegistryDockerImage

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccIapAppEngineServiceIamBindingGenerated

TestAccIapAppEngineServiceIamBindingGenerated_withCondition

TestAccIapAppEngineServiceIamMemberGenerated

TestAccIapAppEngineServiceIamMemberGenerated_withCondition

TestAccIapAppEngineServiceIamPolicyGenerated

TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

modular-magician · 2024-08-01T17:22:18Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccBackupDRBackupVault_backupDrBackupVaultBasicExample[Error message] [Debug log]
TestAccBackupDRBackupVault_backupDrBackupVaultFullExample[Error message] [Debug log]
TestAccBackupDRBackupVault_basicUpdate[Error message] [Debug log]
TestAccBackupDRBackupVault_fullUpdate[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

zli82016 · 2024-08-02T17:46:39Z

/gcbrun

zli82016 · 2024-08-02T17:46:46Z

Rerun the tests

modular-magician · 2024-08-02T18:00:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 210 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 9 files changed, 1400 insertions(+), 6 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 126 insertions(+), 3 deletions(-))

modular-magician · 2024-08-02T19:09:56Z

Tests analytics

Total tests: 3887
Passed tests: 3485
Skipped tests: 385
Affected tests: 17

Click here to see the affected service packages

All service packages are affected

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample

TestAccAppEngineFlexibleAppVersion_update

TestAccAppEngineStandardAppVersion_update

TestAccBackupDRBackupVault_backupDrBackupVaultBasicExample

TestAccBackupDRBackupVault_backupDrBackupVaultFullExample

TestAccBackupDRBackupVault_basicUpdate

TestAccBackupDRBackupVault_fullUpdate

TestAccComputeInstance_bootDisk_storagePoolSpecified

TestAccDataSourceArtifactRegistryDockerImage

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccIapAppEngineServiceIamBindingGenerated

TestAccIapAppEngineServiceIamBindingGenerated_withCondition

TestAccIapAppEngineServiceIamMemberGenerated

TestAccIapAppEngineServiceIamMemberGenerated_withCondition

TestAccIapAppEngineServiceIamPolicyGenerated

TestAccIapAppEngineServiceIamPolicyGenerated_withCondition

TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

modular-magician · 2024-08-02T19:34:38Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_bootDisk_storagePoolSpecified[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample[Error message] [Debug log]
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccBackupDRBackupVault_backupDrBackupVaultBasicExample[Error message] [Debug log]
TestAccBackupDRBackupVault_backupDrBackupVaultFullExample[Error message] [Debug log]
TestAccBackupDRBackupVault_basicUpdate[Error message] [Debug log]
TestAccBackupDRBackupVault_fullUpdate[Error message] [Debug log]
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

zli82016 · 2024-08-02T19:40:54Z

@liyun-huang , do you know how to enable the API on the test project?

The link https://console.developers.google.com/apis/api/autopush-backupdr.sandbox.googleapis.com/overview?project=ci-test-project-188019 in the debug log fails to load.

mmv1/products/backupdr/product.yaml

modular-magician · 2024-08-02T20:22:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 210 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1397 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 123 insertions(+))

modular-magician · 2024-08-02T20:25:25Z

Tests analytics

Total tests: 5
Passed tests: 1
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

backupdr

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_backupDrBackupVaultBasicExample

TestAccBackupDRBackupVault_backupDrBackupVaultFullExample

TestAccBackupDRBackupVault_basicUpdate

TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

modular-magician · 2024-08-27T19:01:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 210 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1323 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 123 insertions(+))

modular-magician · 2024-08-27T19:03:51Z

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

backupdr

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_backupDrBackupVaultFullExample

TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

modular-magician · 2024-08-27T19:06:01Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBackupDRBackupVault_backupDrBackupVaultFullExample[Debug log]
TestAccBackupDRBackupVault_fullUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

liyun-huang · 2024-08-28T15:29:58Z

/gcbrun

modular-magician · 2024-08-28T15:41:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 210 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1323 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 123 insertions(+))

modular-magician · 2024-08-28T15:44:04Z

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

backupdr

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

modular-magician · 2024-08-28T15:46:33Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBackupDRBackupVault_fullUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

liyun-huang · 2024-08-28T17:48:05Z

/gcbrun

modular-magician · 2024-08-28T18:00:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 210 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1323 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 123 insertions(+))

mmv1/products/backupdr/BackupVault.yaml

mmv1/third_party/terraform/services/backupdr/resource_backup_dr_backup_vault_test.go.erb

mmv1/products/backupdr/BackupVault.yaml

mmv1/third_party/terraform/services/backupdr/resource_backup_dr_backup_vault_test.go.erb

modular-magician · 2024-08-28T18:03:18Z

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

backupdr

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

modular-magician · 2024-08-29T20:11:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 210 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1324 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 123 insertions(+))

modular-magician · 2024-08-29T20:13:27Z

Tests analytics

Total tests: 3
Passed tests: 1
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

backupdr

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_backupDrBackupVaultFullExample

TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

modular-magician · 2024-08-29T20:15:51Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBackupDRBackupVault_backupDrBackupVaultFullExample[Debug log]
TestAccBackupDRBackupVault_fullUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

liyun-huang · 2024-08-30T14:36:50Z

/gcbrun

modular-magician · 2024-08-30T14:48:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 210 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1324 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 123 insertions(+))

modular-magician · 2024-08-30T14:51:36Z

Tests analytics

Total tests: 3
Passed tests: 2
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

backupdr

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

modular-magician · 2024-08-30T14:53:58Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBackupDRBackupVault_fullUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

liyun-huang · 2024-08-30T19:13:14Z

/gcbrun

modular-magician · 2024-08-30T19:25:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 210 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 7 files changed, 1324 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 123 insertions(+))

modular-magician · 2024-08-30T19:27:33Z

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

backupdr

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

zli82016

LGTM. Thanks for adding the new resource.

…leCloudPlatform#11317)

Added backupvault resource to Terraform backupdr product.

e0bf280

github-actions bot requested a review from zli82016 July 31, 2024 20:18

Fixed linter

69f7a0a

modular-magician added the service/backupdr label Jul 31, 2024

liyun-huang added 5 commits August 1, 2024 06:51

Added effective-time, annotations, and labels to acceptance test.

d76771f

Dynamic effective-time

bf4404f

Removed print statement

1dc8c79

Fixed BV linter

41472d5

Remvoed beta from import path due to build error.

0a3e4ce

zli82016 reviewed Aug 2, 2024

View reviewed changes

mmv1/products/backupdr/product.yaml Outdated Show resolved Hide resolved

Changed the API url to prod.

6e25c23

github-actions bot requested a review from zli82016 August 2, 2024 20:06

zli82016 requested changes Aug 28, 2024

View reviewed changes

resolved comments

8bc56bf

github-actions bot requested a review from zli82016 August 29, 2024 19:58

zli82016 approved these changes Aug 30, 2024

View reviewed changes

zli82016 changed the title ~~Added backupvault resource to Terraform backupdr product.~~ Added backupvault resource to Terraform backupdr product (beta) Aug 30, 2024

zli82016 merged commit e169437 into GoogleCloudPlatform:main Aug 30, 2024
14 checks passed

iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024

Added backupvault resource to Terraform backupdr product (beta) (Goog…

14f94bc

…leCloudPlatform#11317)

Added backupvault resource to Terraform backupdr product (beta) #11317

Added backupvault resource to Terraform backupdr product (beta) #11317

Conversation

liyun-huang commented Jul 31, 2024 • edited by zli82016 Loading

github-actions bot commented Jul 31, 2024

modular-magician commented Jul 31, 2024

Diff report

Missing test report

modular-magician commented Jul 31, 2024

Diff report

Missing test report

modular-magician commented Jul 31, 2024

Tests analytics

Action taken

modular-magician commented Jul 31, 2024

Tests analytics

Action taken

modular-magician commented Jul 31, 2024

modular-magician commented Jul 31, 2024

modular-magician commented Aug 1, 2024

Diff report

modular-magician commented Aug 1, 2024

Tests analytics

Action taken

modular-magician commented Aug 1, 2024

zli82016 commented Aug 2, 2024

zli82016 commented Aug 2, 2024

modular-magician commented Aug 2, 2024

Diff report

modular-magician commented Aug 2, 2024

Tests analytics

Action taken

modular-magician commented Aug 2, 2024

zli82016 commented Aug 2, 2024

modular-magician commented Aug 2, 2024

Diff report

modular-magician commented Aug 2, 2024

Tests analytics

Action taken

modular-magician commented Aug 27, 2024

Diff report

modular-magician commented Aug 27, 2024

Tests analytics

Action taken

modular-magician commented Aug 27, 2024

liyun-huang commented Aug 28, 2024

modular-magician commented Aug 28, 2024

Diff report

modular-magician commented Aug 28, 2024

Tests analytics

Action taken

modular-magician commented Aug 28, 2024

liyun-huang commented Aug 28, 2024

modular-magician commented Aug 28, 2024

Diff report

modular-magician commented Aug 28, 2024

Tests analytics

modular-magician commented Aug 29, 2024

Diff report

modular-magician commented Aug 29, 2024

Tests analytics

Action taken

modular-magician commented Aug 29, 2024

liyun-huang commented Aug 30, 2024

modular-magician commented Aug 30, 2024

Diff report

modular-magician commented Aug 30, 2024

Tests analytics

Action taken

modular-magician commented Aug 30, 2024

liyun-huang commented Aug 30, 2024

modular-magician commented Aug 30, 2024

Diff report

modular-magician commented Aug 30, 2024

Tests analytics

zli82016 left a comment

Choose a reason for hiding this comment

liyun-huang commented Jul 31, 2024 •

edited by zli82016

Loading