Skip to content

Revert "Add send_age_if_zero field and deprecate no_age. (#11098)" #11404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

NickElliot
Copy link
Contributor

This reverts commit 2b00543.

Release Note Template for Downstream PRs (will be copied)

storage: added `send_age_if_zero` field with default value `true` and deprecated `no_age` field. (revert)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 27 insertions(+), 64 deletions(-))
google-beta provider: Diff ( 4 files changed, 27 insertions(+), 64 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field lifecycle_rule.condition.send_age_if_zero within resource google_storage_bucket was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 107
Passed tests: 97
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages
  • storage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageBucket_lifecycleRulesVirtualFields

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageBucket_lifecycleRulesVirtualFields[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@melinath melinath added the override-breaking-change Allows a potential breaking change to be merged label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged service/storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants