Add tags field to Project resource

[abd-goog]

Add tags field to project resource to allow setting tags on project resources at creation time.
Part of b/330143705

Part of hashicorp/terraform-provider-google#18775

Release Note Template for Downstream PRs (will be copied)

resourcemanager: added `tags` field to `google_project` to allow setting tags for projects at creation time

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 82 insertions(+))
google-beta provider: Diff ( 4 files changed, 91 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (876 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  tags = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 91 insertions(+))
google-beta provider: Diff ( 4 files changed, 91 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (876 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  tags = # value needed
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 91 insertions(+))
google-beta provider: Diff ( 4 files changed, 91 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (876 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 145
Passed tests: 114
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccProject_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccProject_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 145
Passed tests: 114
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccProject_tags

Get to know how VCR tests work

[abd-goog]

Tests failed during RECORDING mode: TestAccProject_tags[Error message] [Debug log]

Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@rileykarson The test passes on local, but would need help from TF team to add the tags resource in the test organization and provide tag admin permission to VCR test user.
Or should I mark this test as skipped?

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccProject_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 145
Passed tests: 114
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccProject_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccProject_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[rileykarson]

Can you create the TagKey inline in the test? We can't scalably manage our environments manually and prefer tests to own their dependencies (and in some rare cases have code to manage bootstrapping them, which this shouldn't need).

[abd-goog]

Can you create the TagKey inline in the test? We can't scalably manage our environments manually and prefer tests to own their dependencies (and in some rare cases have code to manage bootstrapping them, which this shouldn't need).

Hi @rileykarson, I have made changes for inline creation however the test seems to fail in post-destroy because it takes some time for tag binding deletion when delete resource is called...hence delete tag value fails in post test destroy.

Is it necessary to bootstrap in this case?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 96 insertions(+))
google-beta provider: Diff ( 4 files changed, 96 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (868 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 145
Passed tests: 114
Skipped tests: 30
Affected tests: 1

Click here to see the affected service packages

• resourcemanager

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccProject_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccProject_tags[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccProject_tags[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 3921
Passed tests: 3508
Skipped tests: 411
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceTemplate_withNamePrefix
• TestAccProject_tags

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccProject_tags[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccProjectIamPolicy_invalidMembers[Debug log]
TestAccProject_tags[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Debug log]
TestAccProject_tags[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[rileykarson]

Rolling a new reviewer- I've been underwater on reviews, sorry!

[zli82016]

Can you create the TagKey inline in the test? We can't scalably manage our environments manually and prefer tests to own their dependencies (and in some rare cases have code to manage bootstrapping them, which this shouldn't need).

Hi @rileykarson, I have made changes for inline creation however the test seems to fail in post-destroy because it takes some time for tag binding deletion when delete resource is called...hence delete tag value fails in post test destroy.

Is it necessary to bootstrap in this case?

Do you know how long will the tag binding deletion take? After the project is scheduled to be deleted, when the tags can be deleted by the users?

[abd-goog]

Can you create the TagKey inline in the test? We can't scalably manage our environments manually and prefer tests to own their dependencies (and in some rare cases have code to manage bootstrapping them, which this shouldn't need).

Hi @rileykarson, I have made changes for inline creation however the test seems to fail in post-destroy because it takes some time for tag binding deletion when delete resource is called...hence delete tag value fails in post test destroy.
Is it necessary to bootstrap in this case?

Do you know how long will the tag binding deletion take? After the project is scheduled to be deleted, when the tags can be deleted by the users?

TagBindings can take upto 24 hours or more for automatic deletions(binding deletions triggered by resource deletion).

[abd-goog]

@zli82016 the testing is now supported by bootstrapped tagkeys and tagvalues so the deletion delay isn't an issue anymore.

[zli82016]

Can you create the TagKey inline in the test? We can't scalably manage our environments manually and prefer tests to own their dependencies (and in some rare cases have code to manage bootstrapping them, which this shouldn't need).

Hi @rileykarson, I have made changes for inline creation however the test seems to fail in post-destroy because it takes some time for tag binding deletion when delete resource is called...hence delete tag value fails in post test destroy.
Is it necessary to bootstrap in this case?

Do you know how long will the tag binding deletion take? After the project is scheduled to be deleted, when the tags can be deleted by the users?

TagBindings can take upto 24 hours or more for automatic deletions(binding deletions triggered by resource deletion).

Can you help understand the reason that it takes some time for tagbinding automatic deletion? I just tested it locally. After the project is scheduled to be deleted, the tagbinding can be deleted by calling the API immediately. Some users will complain that they have to wait to delete the tags.

[zli82016]

@zli82016 the testing is now supported by bootstrapped tagkeys and tagvalues so the deletion delay isn't an issue anymore.

I see, but it is still a concern for the users, as the users have to wait to delete the tags.

[abd-goog]

@zli82016 the testing is now supported by bootstrapped tagkeys and tagvalues so the deletion delay isn't an issue anymore.

I see, but it is still a concern for the users, as the users have to wait to delete the tags.

That is expected product behavior as of now though. So there's nothing that be done from Terraform's end to modify this behavior.
The bindings are deleted by periodic reconciliation and not instantly to avoid some data loss scenarios.

[zli82016]

@zli82016 the testing is now supported by bootstrapped tagkeys and tagvalues so the deletion delay isn't an issue anymore.

I see, but it is still a concern for the users, as the users have to wait to delete the tags.

That is expected product behavior as of now though. So there's nothing that be done from Terraform's end to modify this behavior. The bindings are deleted by periodic reconciliation and not instantly to avoid some data loss scenarios.

Thanks for the information. Do you mind adding a note that the deletion of tagbinding may take some time after the project is scheduled to be deleted in the doc

magic-modules/mmv1/third_party/terraform/website/docs/r/google_project.html.markdown

Line 22 in 3a8cd91

Also, do you mind adding an example to use the tags to the doc https://github.com/GoogleCloudPlatform/magic-modules/blob/3a8cd91f6603e2b464822646d11cbaab1f2b917f/mmv1/third_party/terraform/website/docs/r/google_project.html.markdown?

Thanks.

[abd-goog]

@zli82016 the testing is now supported by bootstrapped tagkeys and tagvalues so the deletion delay isn't an issue anymore.

I see, but it is still a concern for the users, as the users have to wait to delete the tags.

That is expected product behavior as of now though. So there's nothing that be done from Terraform's end to modify this behavior. The bindings are deleted by periodic reconciliation and not instantly to avoid some data loss scenarios.

Thanks for the information. Do you mind adding a note that the deletion of tagbinding may take some time after the project is scheduled to be deleted in the doc

magic-modules/mmv1/third_party/terraform/website/docs/r/google_project.html.markdown

Line 22 in 3a8cd91

Also, do you mind adding an example to use the tags to the doc https://github.com/GoogleCloudPlatform/magic-modules/blob/3a8cd91f6603e2b464822646d11cbaab1f2b917f/mmv1/third_party/terraform/website/docs/r/google_project.html.markdown?

Thanks.

Added both, PTAL. Thanks.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 237 insertions(+))
google-beta provider: Diff ( 4 files changed, 237 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (885 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  tags = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3808
Passed tests: 3394
Skipped tests: 411
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBackupDRBackupVault_fullUpdate
• TestAccComputeInstanceTemplate_withNamePrefix
• TestAccDataformRepository_updated

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBackupDRBackupVault_fullUpdate[Debug log]
TestAccComputeInstanceTemplate_withNamePrefix[Debug log]
TestAccDataformRepository_updated[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[zli82016]

LGTM

[zli82016]

The failed tests are unrelated.