Skip to content

remove deprecated integration client fields #11450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Aug 14, 2024

fixes hashicorp/terraform-provider-google#17928

Release Note Template for Downstream PRs (will be copied)

integrations: `create_sample_workflows` and `provision_gmek` are removed from `google_integrations_client`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 14 insertions(+), 93 deletions(-))
google-beta provider: Diff ( 5 files changed, 14 insertions(+), 93 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 20 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field create_sample_workflows within resource google_integrations_client was either removed or renamed - reference
  • Field provision_gmek within resource google_integrations_client was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@c2thorn c2thorn added the override-breaking-change Allows a potential breaking change to be merged label Aug 14, 2024
@c2thorn c2thorn requested a review from hao-nan-li August 14, 2024 22:09
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 10
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • integrations

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIntegrationsAuthConfig_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIntegrationsAuthConfig_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged service/integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants