-
Notifications
You must be signed in to change notification settings - Fork 1.8k
KMS
: add google_kms_crypto_key_latest_version
data source
#11456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KMS
: add google_kms_crypto_key_latest_version
data source
#11456
Conversation
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
1 similar comment
Tests analyticsTotal tests: 40 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Tests analyticsTotal tests: 40 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Tests analyticsTotal tests: 40 Click here to see the affected service packages
View the build log |
Tests analyticsTotal tests: 40 Click here to see the affected service packages
View the build log |
9e874e0
to
5943a64
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Marking as ready for review after including the docs, I'm requesting specifically @slevenick due to already reviewing the plural data source. There's not much to review from this PR since it depends on the logic of plural |
Tests analyticsTotal tests: 40 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 40 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 40 Click here to see the affected service packages
View the build log |
mmv1/third_party/terraform/services/kms/data_source_google_kms_crypto_key_latest_version.go
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 40 Click here to see the affected service packages
View the build log |
@slevenick thanks again for reviewing both PRs! 😄 |
Continuation of #11455
Second step where we focus on grabbing the latest crypto key version (singular data source)
This PR depends on the referenced PR, plural data source must be merged before this can be properly reviewed.
The only major difference is once the list of cryptoKeyVersions is set we grab the latest one which is done in this line here:
https://github.com/GoogleCloudPlatform/magic-modules/pull/11456/files#diff-7c2dc734dd72075cca3912ca10f4c3a3736ea934186f1392fc7e0764a37eac53R99-R103
filter is added in since it gives the user the ability to grab the latest in either the enabled state or disabled state.
PR also includes some clean up of the plural
cryptoKeyVersions
data source such as adding in the missing filter argument in the docs.Test passing:
Release Note Template for Downstream PRs (will be copied)