Validate that subnetwork_project should match with the project in subnetwork field in google_compute_instance resource

[karolgorc]

closes hashicorp/terraform-provider-google#15749

The subnetwork_project field is ignored in the API request when a self_link is given in subnetwork, but not in terraform which is correct behavior because subnetwork_project is still in the code. Suppressing a diff on this seems unreasonable because providing something like this isn't really a valid config

subnetwork_project = "projectA"
subnetwork = "...projectB..."

Maybe throw an error when this happens?

Release Note Template for Downstream PRs (will be copied)

compute: validated that `network_interface.subnetwork_project` should match with the project in `network_interface. subnetwork` field when `network_interface.subnetwork` has full self_link in `google_compute_instance` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[karolgorc]

that unit-test fail doesn't seem related

[zli82016]

The subnetwork_project field is ignored in the API request when a self_link is given in subnetwork, but not in terraform which is correct behavior because subnetwork_project is still in the code. Suppressing a diff on this seems unreasonable because providing something like this isn't really a valid config

subnetwork_project = "projectA"
subnetwork = "...projectB..."

Maybe throw an error when this happens?

Throwing an error is a good idea to let the user know that the provided subnetwork_project is not correct.

[zli82016]

Can you please add the validation? Thanks.

[karolgorc]

• Added GetProjectFromRegionalSelfLink to tpgresource and a unit test for it
• Added the new logic to CustomizeDiff

This isn't really a simple field validation to use ValidateFunc because it depends on an external value which isn't really supported by the types used in ValidateFunc, StateFunc or DiffSuppressFunc.

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 55 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 55 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3921
Passed tests: 3509
Skipped tests: 411
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestGetProjectFromRegionalSelfLink

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 55 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 55 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3923
Passed tests: 3510
Skipped tests: 411
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestGetProjectFromRegionalSelfLink

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceTemplate_withNamePrefix
• TestAccComputeTargetHttpsProxy_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Debug log]
TestAccComputeTargetHttpsProxy_update[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[karolgorc]

Got the same test fails in 2 other PR's. Don't think they are related.

[zli82016]

Thank you for adding the validation.

Do you mind adding an acceptance test to check if the incorrect configuration for subnetwork_project will return error in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/compute/resource_compute_instance_test.go.erb?

Example: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/services/alloydb/resource_alloydb_cluster_restore_test.go#L39-L42

[karolgorc]

Done

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 111 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 5 files changed, 111 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 3934
Passed tests: 3520
Skipped tests: 412
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestGetProjectFromRegionalSelfLink

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceTemplate_withNamePrefix
• TestAccComputeInstance_subnetworkProjectMustMatchError

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Debug log]
TestAccComputeInstance_subnetworkProjectMustMatchError[Debug log]
$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[github-actions]

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @zli82016 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[zli82016]

LGTM. Thanks for adding the validation. The failed tests are unrelated.