Skip to content

Add http_target field to google_cloud_tasks_queue #11544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

toga4
Copy link
Contributor

@toga4 toga4 commented Aug 25, 2024

This PR adds support for queue-level routing in Cloud Tasks.

Fixes hashicorp/terraform-provider-google#15022.

The doc of REST Resource: projects.locations.queues describes httpTarget property in Queue resource.

Release Note Template for Downstream PRs (will be copied)

cloudtasks: added `http_target` field to `google_cloud_tasks_queue` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 25, 2024
@toga4 toga4 marked this pull request as ready for review August 25, 2024 12:34
@github-actions github-actions bot requested a review from hao-nan-li August 25, 2024 12:35
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/cloudtasks and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1234 insertions(+))
google-beta provider: Diff ( 4 files changed, 1234 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 297 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 282 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_tasks_queue (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_tasks_queue" "primary" {
  http_target {
    uri_override {
      uri_override_enforce_mode = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 9
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • cloudtasks

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudTasksQueue_HttpTargetOAuth_update
  • TestAccCloudTasksQueue_HttpTargetOIDC_update
  • TestAccCloudTasksQueue_cloudTasksQueueHttpTargetOauthExample
  • TestAccCloudTasksQueue_cloudTasksQueueHttpTargetOidcExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudTasksQueue_HttpTargetOAuth_update[Debug log]
TestAccCloudTasksQueue_HttpTargetOIDC_update[Debug log]
TestAccCloudTasksQueue_cloudTasksQueueHttpTargetOauthExample[Debug log]
TestAccCloudTasksQueue_cloudTasksQueueHttpTargetOidcExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1240 insertions(+))
google-beta provider: Diff ( 4 files changed, 1240 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 297 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 284 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 13
Passed tests: 9
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • cloudtasks

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudTasksQueue_HttpTargetOAuth_update
  • TestAccCloudTasksQueue_HttpTargetOIDC_update
  • TestAccCloudTasksQueue_cloudTasksQueueHttpTargetOauthExample
  • TestAccCloudTasksQueue_cloudTasksQueueHttpTargetOidcExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudTasksQueue_HttpTargetOAuth_update[Debug log]
TestAccCloudTasksQueue_HttpTargetOIDC_update[Debug log]
TestAccCloudTasksQueue_cloudTasksQueueHttpTargetOauthExample[Debug log]
TestAccCloudTasksQueue_cloudTasksQueueHttpTargetOidcExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for queue level routing in Cloud Tasks
3 participants