Adds support for Filestore instance new feature: deletion protection.

[boarik]

Users will be able to enable deletion protection on their new or existing Filestore instances by providing an instance's deletion_protection_enabled boolean field and optionally also deletion_protection_reason string field specifying the reason for enabling the protection.

Fixes hashicorp/terraform-provider-google#19336

Release Note Template for Downstream PRs (will be copied)

filestore: added `deletion_protection_enabled` and `deletion_protection_reason` fields to `google_filestore_instance`

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 161 insertions(+))
google-beta provider: Diff ( 3 files changed, 161 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_deletionProtection_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFilestoreInstance_deletionProtection_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[boarik]

The failed VCR-test is due to API rollout changes that are in progress (should be finished very soon) and due to experiments not yet being fully ramped up yet. I'd appreciate a review regardless to move things forward in the meantime.
Thanks

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[boarik]

@rileykarson The experiments + API rollout dependencies that caused the test failure should be now resolved. Can you assist re-running the checks to validate all works?

[github-actions]

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[rileykarson]

/gcbrun

[rileykarson]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 161 insertions(+))
google-beta provider: Diff ( 3 files changed, 161 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccFilestoreInstance_deletionProtection_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFilestoreInstance_deletionProtection_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[rileykarson]

Mostly LGTM- one small test change to add an ImportState step after one of the Config steps.

I did want to flag that if we add a clientside deletion protection in the future we'll need to reconcile the fields [our thoughts on deletion_protection]. Given we don't have one I think this is still the right change to make anyways.

[boarik]

@rileykarson back to you. Thanks

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 167 insertions(+))
google-beta provider: Diff ( 3 files changed, 167 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 12
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• filestore

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log