Skip to content

google_network_connectivity_spoke: add include_export_ranges #11609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

prauc
Copy link
Contributor

@prauc prauc commented Sep 2, 2024

This PR adds the field includeExportRanges for VPC Spokes in NCC. It was somehow missing in our terraform provider.

https://cloud.google.com/network-connectivity/docs/reference/networkconnectivity/rest/Shared.Types/Spoke#LinkedVpcNetwork

Tests for networkconnectivity were already successfully executed locally

Release Note Template for Downstream PRs (will be copied)

networkconnectivity: added `include_export_ranges` to `google_network_connectivity_spoke`

Copy link

github-actions bot commented Sep 2, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 54 insertions(+))
google-beta provider: Diff ( 4 files changed, 54 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 4 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 22
Passed tests: 19
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
  • TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten[Debug log]
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm[Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@ScottSuarez ScottSuarez merged commit e30f86c into GoogleCloudPlatform:main Sep 3, 2024
15 checks passed
@ScottSuarez
Copy link
Contributor

Thanks for the work !!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants