-
Notifications
You must be signed in to change notification settings - Fork 1.8k
google_network_connectivity_spoke
: add include_export_ranges
#11609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google_network_connectivity_spoke
: add include_export_ranges
#11609
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 22 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Thanks for the work !!! :) |
This PR adds the field
includeExportRanges
for VPC Spokes in NCC. It was somehow missing in our terraform provider.https://cloud.google.com/network-connectivity/docs/reference/networkconnectivity/rest/Shared.Types/Spoke#LinkedVpcNetwork
Tests for networkconnectivity were already successfully executed locally
Release Note Template for Downstream PRs (will be copied)