Fix google_dns_record_set with same name throw an error

[Samir-Cit]

This PR fixes the issue hashicorp/terraform-provider-google#10661 by removing the piece of code that prevents the error when creating a resource with a name that already exists.

Release Note Template for Downstream PRs (will be copied)

dns: added a mutex to `google_dns_record_set` to prevent conflicts when multiple resources attempt to operate on the same record set

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

After discussion with the team on this, I think the best course of action is to add a mutex to this resource to prevent the 409 conflict situations described in the linked bug.

We don't want to remove this code as it will make the resource unauthoritative, which some users may currently depend on. If we're convinced we want to make it unauthoritative we could consider that in a major version, but until then we should limit the change to adding a mutex

[Samir-Cit]

Suggestion applied to use mutex instead of removing the code.

[slevenick]

/gcbrun I think I messed something up

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 16 insertions(+))
google-beta provider: Diff ( 1 file changed, 16 insertions(+))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• dns

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

[slevenick]

Compilation errors

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 18 insertions(+))
google-beta provider: Diff ( 1 file changed, 18 insertions(+))

[modular-magician]

Tests analytics

Total tests: 47
Passed tests: 46
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• dns

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[slevenick]

Thanks!