add AutoTier support for netapp storagePools and Volumes #11645

Mehul3217 · 2024-09-05T18:58:51Z

Release Note Template for Downstream PRs (will be copied)

netapp: added `allow_auto_tiering` field to StoragePool and  `tiering_policy` field to Volume resource

github-actions · 2024-09-05T18:59:30Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2024-09-05T19:11:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 266 insertions(+))
google-beta provider: Diff ( 6 files changed, 266 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-05T19:13:22Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician · 2024-09-05T19:42:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 266 insertions(+))
google-beta provider: Diff ( 6 files changed, 266 insertions(+))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-05T20:00:06Z

Tests analytics

Total tests: 18
Passed tests: 16
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-09-05T20:06:51Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappStoragePool_storagePoolCreateExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappVolume_NetappVolumeBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-09-06T10:08:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 267 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 6 files changed, 267 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-06T10:13:09Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 262 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 6 files changed, 262 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-06T10:56:31Z

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-09-06T11:01:07Z

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-09-06T11:05:41Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappVolume_NetappVolumeBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-09-06T11:33:39Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappVolume_NetappVolumeBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

rileykarson · 2024-09-06T16:26:22Z

mmv1/third_party/terraform/services/netapp/resource_netapp_storage_pool_test.go.erb

@@ -41,6 +41,15 @@ func TestAccNetappStoragePool_storagePoolCreateExample_update(t *testing.T) {
 				ImportStateVerify:       true,
 				ImportStateVerifyIgnore: []string{"location", "name", "labels", "terraform_labels"},
 			},
+			{
+				Config: testAccNetappStoragePool_storagePoolCreateExample_autoTieredPool(context),


Since this is immutable, it should get covered in single-step test, probably a new one!

mmv1/third_party/terraform/services/netapp/resource_netapp_volume_test.go

modular-magician · 2024-09-07T10:42:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 336 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 6 files changed, 336 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-07T10:46:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 299 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 6 files changed, 299 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-07T11:31:07Z

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-09-07T11:32:47Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappVolume_autoTieredNetappVolumeExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-09-07T11:34:18Z

Tests analytics

Total tests: 20
Passed tests: 18
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-09-07T11:35:54Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappVolume_autoTieredNetappVolumeExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappStoragePool_autoTieredStoragePoolCreateExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician · 2024-09-10T17:04:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 299 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 6 files changed, 299 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-10T17:24:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 338 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 6 files changed, 338 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-10T17:53:44Z

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-09-10T17:55:36Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappVolume_autoTieredNetappVolume[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician · 2024-09-10T18:13:29Z

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-09-10T18:14:56Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetappVolume_autoTieredNetappVolume_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

rileykarson

We seem to have hit an API bug on update- the update mask is getting rejected, but looks well-formed.

modular-magician · 2024-09-11T01:51:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 299 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 6 files changed, 299 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-11T02:39:20Z

Tests analytics

Total tests: 20
Passed tests: 20
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

rileykarson

In addition to removing the update step we also need to remove update support by marking tieringPolicy and its children immutable. We should not ship a broken field to end users.

Mehul3217 · 2024-09-11T18:17:36Z

We can update the tierringPolicy children tier action between paused to enable, and update cooling threshold days. We can't remove tiering policy

So we cannot make them immutable

rileykarson · 2024-09-11T18:19:35Z

Yes, we can make them mutable later when update works- in the meantime we need to mark them as immutable because Terraform will fail to update them.

modular-magician · 2024-09-12T12:01:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 337 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 6 files changed, 337 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 2 files changed, 50 insertions(+))

modular-magician · 2024-09-12T12:50:07Z

Tests analytics

Total tests: 20
Passed tests: 19
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-09-12T12:52:19Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetappVolume_autoTieredNetappVolume_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

rileykarson · 2024-09-12T16:10:07Z

mmv1/products/netapp/Volume.yaml

+    name: tieringPolicy
+    description: |-
+      Tiering policy for the volume.
+    update_mask_fields:


non-actionable: I'll flag that requiring this means an AIP is being broken, as the top-level field should have been sufficient: https://google.aip.dev/161#specifying-specific-fields

…Platform#11645) Co-authored-by: Riley Karson <[email protected]>

Mehul3217 added 3 commits September 5, 2024 18:46

add AutoTier support for netapp storagePools and Volumes

c7c4c2a

add tests for AutoTier

91bf13a

modify tests for storagePool & Volume

534abe2

github-actions bot requested a review from rileykarson September 5, 2024 18:59

modular-magician added the service/netapp label Sep 5, 2024

fix typo in testName

b57223c

Mehul3217 added 2 commits September 6, 2024 09:55

update autoTier test for Volume

1b3e302

create new test for autoTier Volumes

23b73d5

rileykarson reviewed Sep 6, 2024

View reviewed changes

add separate tests for Netapp AT storagePool & Volumes

4fa927f

github-actions bot requested a review from rileykarson September 7, 2024 10:31

remove AutoTier volume test duplication

128ed52

github-actions bot requested a review from rileykarson September 10, 2024 16:51

add update test for autoTiered Volume

061be8b

rileykarson reviewed Sep 10, 2024

View reviewed changes

add single step test for autoTiered Volume

9cee1a7

github-actions bot requested a review from rileykarson September 11, 2024 01:39

rileykarson requested changes Sep 11, 2024

View reviewed changes

github-actions bot requested a review from rileykarson September 11, 2024 18:18

add update_mask_fields to tieringPolicy in netapp volume

ce29778

rileykarson approved these changes Sep 12, 2024

View reviewed changes

rileykarson merged commit 7a2585c into GoogleCloudPlatform:main Sep 12, 2024
13 checks passed

iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024

add AutoTier support for netapp storagePools and Volumes (GoogleCloud…

c0ead50

…Platform#11645) Co-authored-by: Riley Karson <[email protected]>

abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024

add AutoTier support for netapp storagePools and Volumes (GoogleCloud…

dcaf846

…Platform#11645) Co-authored-by: Riley Karson <[email protected]>

niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024

add AutoTier support for netapp storagePools and Volumes (GoogleCloud…

0b0fb76

…Platform#11645) Co-authored-by: Riley Karson <[email protected]>

Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024

add AutoTier support for netapp storagePools and Volumes (GoogleCloud…

beb3dec

…Platform#11645) Co-authored-by: Riley Karson <[email protected]>

add AutoTier support for netapp storagePools and Volumes #11645

add AutoTier support for netapp storagePools and Volumes #11645

Conversation

Mehul3217 commented Sep 5, 2024

github-actions bot commented Sep 5, 2024

modular-magician commented Sep 5, 2024

Diff report

modular-magician commented Sep 5, 2024

Tests analytics

modular-magician commented Sep 5, 2024

Diff report

modular-magician commented Sep 5, 2024

Tests analytics

Action taken

modular-magician commented Sep 5, 2024

modular-magician commented Sep 6, 2024

Diff report

modular-magician commented Sep 6, 2024

Diff report

modular-magician commented Sep 6, 2024

Tests analytics

Action taken

modular-magician commented Sep 6, 2024

Tests analytics

Action taken

modular-magician commented Sep 6, 2024

modular-magician commented Sep 6, 2024

rileykarson Sep 6, 2024

Choose a reason for hiding this comment

Mehul3217 Sep 7, 2024

Choose a reason for hiding this comment

modular-magician commented Sep 7, 2024

Diff report

modular-magician commented Sep 7, 2024

Diff report

modular-magician commented Sep 7, 2024

Tests analytics

Action taken

modular-magician commented Sep 7, 2024

modular-magician commented Sep 7, 2024

Tests analytics

Action taken

modular-magician commented Sep 7, 2024

modular-magician commented Sep 10, 2024

Diff report

modular-magician commented Sep 10, 2024

Diff report

modular-magician commented Sep 10, 2024

Tests analytics

Action taken

modular-magician commented Sep 10, 2024

modular-magician commented Sep 10, 2024

Tests analytics

Action taken

modular-magician commented Sep 10, 2024

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Sep 11, 2024

Diff report

modular-magician commented Sep 11, 2024

Tests analytics

rileykarson left a comment

Choose a reason for hiding this comment

Mehul3217 commented Sep 11, 2024

rileykarson commented Sep 11, 2024

modular-magician commented Sep 12, 2024

Diff report

modular-magician commented Sep 12, 2024

Tests analytics

Action taken

modular-magician commented Sep 12, 2024

rileykarson Sep 12, 2024

Choose a reason for hiding this comment