Skip to content

remove community checker code and update trigger targets #11646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ScottSuarez
Copy link
Contributor

Phase two of community checker cleanup
https://docs.google.com/document/d/1gexRcHdMxDxyPZoNhcPUn2CCAgeK92JFLnk0neQ5Y1k/edit?tab=t.0
Release Note Template for Downstream PRs (will be copied)


@ScottSuarez ScottSuarez requested a review from melinath September 5, 2024 19:40
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the new secrets have soaked for a while, so updating the code should be safe.

ScottSuarez and others added 2 commits September 5, 2024 15:21
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez merged commit 8a1e701 into GoogleCloudPlatform:main Sep 6, 2024
10 checks passed
@ScottSuarez ScottSuarez deleted the community-checker-cleanup branch September 6, 2024 15:03
entertvl pushed a commit to entertvl/magic-modules that referenced this pull request Sep 9, 2024
iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants