feat(apigee): Add support for NatAddress activation

[entertvl]

• fix Add new resource or modify existing google_apigee_nat_address resource for activating NAT address on the Apigee X instance hashicorp/terraform-provider-google#13914

Release Note Template for Downstream PRs (will be copied)

apigee: Add support for NAT Address activation in `google_apigee_nat_address`.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[entertvl]

Trying to set the activate in our custom_import based on state value, but this seems like a wrong approach, d.Get("state").(string) is returning empty.

It doesn’t seem to be mentioned in the guide, but is it necessary to retrieve the state again from the API in rescueApigeeNatAddressImport()...?

func resourceApigeeNatAddressImport(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {
	config := meta.(*transport_tpg.Config)

	(snip)

	state := d.Get("state").(string)

	if err := d.Set("activate", state == "ACTIVE"); err != nil {
		return nil, fmt.Errorf("Error setting NatAddress %s activate: %s", name, err)
	}

	return []*schema.ResourceData{d}, nil
}

[trodge]

Trying to set the activate in our custom_import based on state value, but this seems like a wrong approach, d.Get("state").(string) is returning empty.

It doesn’t seem to be mentioned in the guide, but is it necessary to retrieve the state again from the API in rescueApigeeNatAddressImport()...?

func resourceApigeeNatAddressImport(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) {
	config := meta.(*transport_tpg.Config)

	(snip)

	state := d.Get("state").(string)

	if err := d.Set("activate", state == "ACTIVE"); err != nil {
		return nil, fmt.Errorf("Error setting NatAddress %s activate: %s", name, err)
	}

	return []*schema.ResourceData{d}, nil
}

I don't think import will have access to any API-side data about the resource. Is it possible to do what you need to do in the read method?

[entertvl]

Is it possible to do what you need to do in the read method?

Resolved using encoder/decoder. Thanks.

PR is ready for review. Could you take a look?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 387 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 387 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 43 insertions(+))

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 14
Skipped tests: 29
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccApigeeNatAddress_apigeeNatAddressUpdateTest
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[entertvl]

What reason of failed to terraform-google-conversion-test-integration step?
I don't know how the next.

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[trodge]

/gcbrun

[trodge]

My apologies, that test has been a bit flakey since the 6.0.0 changes. I'm trying re-running the tests. If that fails, rebasing this PR may fix it.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 387 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 387 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 43 insertions(+))

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 14
Skipped tests: 29
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccApigeeNatAddress_apigeeNatAddressUpdateTest
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[entertvl]

Rebased and checked that the re-run tests passed locally.

--- PASS: TestAccApigeeNatAddress_apigeeNatAddressBasicTestExample (2463.60s)
--- PASS: TestAccApigeeNatAddress_apigeeNatAddressUpdateTest (2579.36s)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 387 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 387 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 43 insertions(+))

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 14
Skipped tests: 29
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccApigeeNatAddress_apigeeNatAddressUpdateTest
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 387 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 387 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 16 insertions(+))

[modular-magician]

Tests analytics

Total tests: 43
Passed tests: 14
Skipped tests: 29
Affected tests: 0

Click here to see the affected service packages

• apigee

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccApigeeNatAddress_apigeeNatAddressUpdateTest
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log