Skip to content

gkehub: remove google_gke_hub_membership deprecated description field from example #11808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

philipsabri
Copy link
Contributor

@philipsabri philipsabri commented Sep 25, 2024

Removes the deprecated description field from google_gke_hub_membership in an example to avoid confusion. The field is not used in any other examples.

Release Note Template for Downstream PRs (will be copied)

gkehub: remove `google_gke_hub_membership` deprecated `description` field from example

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 25, 2024
@c2thorn
Copy link
Member

c2thorn commented Sep 25, 2024

Hi @philipsabri,
The repository had a language migration today. You can find the correct file you need to change here: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/examples/gkehub_feature_multi_cluster_ingress.tf.tmpl

@philipsabri philipsabri force-pushed the gkehub-membership-update-example branch from af9cc44 to 46aa88d Compare September 25, 2024 19:48
@modular-magician modular-magician added service/gkehub and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 25, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 deletion(-))

Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Oct 2, 2024

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Oct 9, 2024

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@rileykarson rileykarson merged commit a3338d7 into GoogleCloudPlatform:main Oct 9, 2024
9 checks passed
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 10, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
@philipsabri philipsabri deleted the gkehub-membership-update-example branch November 1, 2024 09:17
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants